public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: Petr Vorel <pvorel@suse.cz>
Cc: gnoack@google.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 5/5] Add landlock06 test
Date: Fri, 26 Jul 2024 15:51:29 +0200	[thread overview]
Message-ID: <20240726.Moowae0jipai@digikod.net> (raw)
In-Reply-To: <20240726132440.GC1066866@pevik>

On Fri, Jul 26, 2024 at 03:24:40PM +0200, Petr Vorel wrote:
> Hi Andrea,
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> Few notes below.
> 
> ...
> > +static struct tst_test test = {
> > +	.test_all = run,
> > +	.setup = setup,
> > +	.cleanup = cleanup,
> > +	.min_kver = "6.10",
> nit: would not be able to check the availablity via landlock ABI == 5?

Because Landlock is available since 5.13, I guess min_kver should be set
to the same version.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-07-26 13:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  9:23 [LTP] [PATCH v4 0/5] landlock testing suite Andrea Cervesato
2024-07-25  9:23 ` [LTP] [PATCH v4 1/5] Add landlock03 test Andrea Cervesato
2024-07-26 11:01   ` Petr Vorel
2024-07-26 11:44     ` Andrea Cervesato via ltp
2024-07-25  9:23 ` [LTP] [PATCH v4 2/5] Add CAP_MKNOD fallback in lapi/capability.h Andrea Cervesato
2024-07-26 13:11   ` Petr Vorel
2024-07-25  9:23 ` [LTP] [PATCH v4 3/5] Add landlock04 test Andrea Cervesato
2024-07-26 13:06   ` Petr Vorel
2024-07-26 16:31   ` Petr Vorel
2024-07-25  9:23 ` [LTP] [PATCH v4 4/5] Add landlock05 test Andrea Cervesato
2024-07-25  9:23 ` [LTP] [PATCH v4 5/5] Add landlock06 test Andrea Cervesato
2024-07-26 13:24   ` Petr Vorel
2024-07-26 13:51     ` Mickaël Salaün [this message]
2024-07-26 14:32       ` Petr Vorel
2024-07-26 16:16         ` Petr Vorel
2024-07-26 16:21     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726.Moowae0jipai@digikod.net \
    --to=mic@digikod.net \
    --cc=gnoack@google.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox