From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: Stephen Bertram <sbertram@redhat.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] cachestat: remove .min_kver from cachestat tests
Date: Fri, 26 Jul 2024 08:52:05 +0200 [thread overview]
Message-ID: <20240726065205.GA1017966@pevik> (raw)
In-Reply-To: <b8c4a02f-d108-42d0-8da1-aa4000f789bd@suse.com>
Hi Li, Andrea,
> Hi!
> On 7/26/24 04:44, Li Wang wrote:
> > Removing the kernel version check (.min_kver) from the cachestat
> > tests to allow the test to run on distributions that backport the
> > cachestat syscall.
> > With no support just skip as TCONF:
> > ../../../../include/lapi/mman.h:40: TCONF: syscall(451) __NR_cachestat not supported on your arch
+1. Just for sure, tested on 6.4 based SLES 15-SP6 and it works as expected (TCONF)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Maybe we should document, that ideally we should try to avoid .min_kver unless
really needed. It's also kind of a documentation, but kernel version can be
specified in metadata documentation.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-26 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 2:44 [LTP] [PATCH] cachestat: remove .min_kver from cachestat tests Li Wang
2024-07-26 6:04 ` Andrea Cervesato via ltp
2024-07-26 6:52 ` Petr Vorel [this message]
2024-07-26 7:52 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726065205.GA1017966@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
--cc=sbertram@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox