From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7362BC3DA4A for ; Fri, 26 Jul 2024 14:33:06 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D0F943D1B0E for ; Fri, 26 Jul 2024 16:33:04 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CDA123C60BA for ; Fri, 26 Jul 2024 16:32:49 +0200 (CEST) Authentication-Results: in-2.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 55392600437 for ; Fri, 26 Jul 2024 16:32:49 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 797431F82D; Fri, 26 Jul 2024 14:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722004368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuU0+PpfEaEgg+YuKDD8mXRxA9Py0HvXZ48wicTlqaI=; b=NnED5jMvdToxPLZvr3v9vCIkByhJO5qclKfzw1DhfBhxtz6YPvzymGmBhjz29m/YWcT4D3 nQAM85J6cakbGKkoaaKEvCfz8WTttEflQI3dovO06XYY7BsCW870AyZhKd6HkNLm2RN+K4 0hveE8Rub8K2T7oeKcko/i+7bpTX+U4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722004368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuU0+PpfEaEgg+YuKDD8mXRxA9Py0HvXZ48wicTlqaI=; b=SINx+rZ4Jpq9J/paR3aXeNjbUYHYKl39PNecWYcpU/m3GUKi1LS76rbAP3fWUXvqVkJT2Y bFJ2S9eqPJ6DXSDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722004368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuU0+PpfEaEgg+YuKDD8mXRxA9Py0HvXZ48wicTlqaI=; b=NnED5jMvdToxPLZvr3v9vCIkByhJO5qclKfzw1DhfBhxtz6YPvzymGmBhjz29m/YWcT4D3 nQAM85J6cakbGKkoaaKEvCfz8WTttEflQI3dovO06XYY7BsCW870AyZhKd6HkNLm2RN+K4 0hveE8Rub8K2T7oeKcko/i+7bpTX+U4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722004368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuU0+PpfEaEgg+YuKDD8mXRxA9Py0HvXZ48wicTlqaI=; b=SINx+rZ4Jpq9J/paR3aXeNjbUYHYKl39PNecWYcpU/m3GUKi1LS76rbAP3fWUXvqVkJT2Y bFJ2S9eqPJ6DXSDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4ECD5138A7; Fri, 26 Jul 2024 14:32:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Xzw1EpCzo2ZRIQAAD6G6ig (envelope-from ); Fri, 26 Jul 2024 14:32:48 +0000 Date: Fri, 26 Jul 2024 16:32:46 +0200 From: Petr Vorel To: =?iso-8859-2?Q?Micka=EBl_Sala=FCn?= Message-ID: <20240726143246.GB1104577@pevik> References: <20240725-landlock-v4-0-66f5a1c0c693@suse.com> <20240725-landlock-v4-5-66f5a1c0c693@suse.com> <20240726132440.GC1066866@pevik> <20240726.Moowae0jipai@digikod.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240726.Moowae0jipai@digikod.net> X-Spamd-Result: default: False [-4.30 / 50.00]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,suse.cz:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 5/5] Add landlock06 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: gnoack@google.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On Fri, Jul 26, 2024 at 03:24:40PM +0200, Petr Vorel wrote: > > Hi Andrea, > > Reviewed-by: Petr Vorel > > Few notes below. > > ... > > > +static struct tst_test test = { > > > + .test_all = run, > > > + .setup = setup, > > > + .cleanup = cleanup, > > > + .min_kver = "6.10", > > nit: would not be able to check the availablity via landlock ABI == 5? > Because Landlock is available since 5.13, I guess min_kver should be set > to the same version. If anybody backport this, kernel version will not match. IMHO it's better to avoid specifying version if we can detect with something else (ABI version in this case). Also avoid kernel config reading if not needed is IMHO better. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp