Re: [LTP] [PATCH v4 5/5] Add landlock06 test

[Petr Vorel <pvorel@suse.cz>]

> > On Fri, Jul 26, 2024 at 03:24:40PM +0200, Petr Vorel wrote:
> > > Hi Andrea,

> > > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > > Few notes below.

> > > ...
> > > > +static struct tst_test test = {
> > > > +	.test_all = run,
> > > > +	.setup = setup,
> > > > +	.cleanup = cleanup,
> > > > +	.min_kver = "6.10",
> > > nit: would not be able to check the availablity via landlock ABI == 5?

> > Because Landlock is available since 5.13, I guess min_kver should be set
> > to the same version.

> If anybody backport this, kernel version will not match. IMHO it's better to
> avoid specifying version if we can detect with something else (ABI version in
> this case). Also avoid kernel config reading if not needed is IMHO better.

Although functionality is not backported often to the enterprise kernels (e.g.
SLES, RHEL), certain things are backported, e.g. [1]. And that is the reason why
LTP even has a way to detect enterprise kernel [2]. Obviously the easiest thing
is to avoid kernel version if there is way to detect functionality by different
way.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/commit/c354ba291da3e255c135ef78da0c7b8c5556da07
[2] https://github.com/linux-test-project/ltp/blob/master/lib/tst_kvercmp.c#L131

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp