Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Petr Vorel <pvorel@suse.cz>]

Hi all,

> sched_football is useful not only for testing realtime,
> therefore add it also to runtest/sched.

> This depends on previous commit which enabled realtime by default.
> We ignore the possibility realtime tests are disabled.

> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  runtest/sched | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/runtest/sched b/runtest/sched
> index 5dab7a4c27..ecedd1a92b 100644
> --- a/runtest/sched
> +++ b/runtest/sched
> @@ -18,3 +18,5 @@ sched_cli_serv run_sched_cliserv.sh
>  sched_stress sched_stress.sh

>  autogroup01 autogroup01
> +
> +sched_football sched_football

I'm sorry, I haven't noticed, that realtime installs into a different directory:

cd ltp/testcases/realtime/func/sched_football
# make install
mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

Therefore scripts which expect it to have in the usual path $LTPROOT/testcases/bin
(e.g. /opt/ltp/testcases/bin) fail.

As temporary solution is to add $LTPROOT/testcases/realtime/func/sched_football/
to $PATH, for proper fix we have possibilities:

1) Either move sched_football.c out of realtime package (thus have some
duplicity, because it needs some of librealtime.a code),
2) or fully integrate realtime testsuite to LTP (e.g. convert librealtime.a to
normal LTP library in libs/ directory).
3) Change realtime make install target to install to $LTPROOT/testcases/bin and
ignore that some tests are not much useful for non-realtime kernels.

Just a reminder, to help which decision is better we have ticket for realtime
where is Mel Gorman's realtime usability investigation [1].

Because some time ago we planned to move tests to rt-tests testsuite [2] (we did
not consider to run them for non-realtime kernels, but recently Cyril saw
sched_football useful also for non-realtime kernels).

Do we plan to keep only sched_football in LTP or all tests? I suppose LTP should
only contains tests which are useful also for non-realtime kernels.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/issues/1078#issuecomment-2212913818
[2] https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp