[LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup

[LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup

[Petr Vorel]

Petr Vorel (6):
  configure: Print info about TI-RPC testsuite in summary
  configure: Don't assume testcases/realtime/configure.ac
  configure: Print info about KVM testsuite in summary
  configure: Enable realtime testsuite by default
  runtest/sched: Add sched_football
  realtime: Use proper syntax for non-system include

 configure.ac                                        | 13 +++++++++----
 include/mk/features.mk.in                           |  3 ---
 runtest/sched                                       |  2 ++
 testcases/Makefile                                  |  4 ----
 .../realtime/func/async_handler/async_handler.c     |  4 ++--
 .../realtime/func/async_handler/async_handler_jk.c  |  4 ++--
 .../realtime/func/async_handler/async_handler_tsc.c |  4 ++--
 .../realtime/func/gtod_latency/gtod_infinite.c      |  2 +-
 testcases/realtime/func/gtod_latency/gtod_latency.c |  4 ++--
 testcases/realtime/func/hrtimer-prio/hrtimer-prio.c |  4 ++--
 testcases/realtime/func/matrix_mult/matrix_mult.c   |  4 ++--
 .../realtime/func/measurement/preempt_timing.c      |  2 +-
 testcases/realtime/func/measurement/rdtsc-latency.c |  2 +-
 .../func/periodic_cpu_load/periodic_cpu_load.c      |  4 ++--
 .../periodic_cpu_load/periodic_cpu_load_single.c    |  4 ++--
 testcases/realtime/func/pi-tests/test-skeleton.c    |  2 +-
 testcases/realtime/func/pi-tests/testpi-0.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-1.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-2.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-4.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-5.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-6.c         |  2 +-
 testcases/realtime/func/pi-tests/testpi-7.c         |  2 +-
 testcases/realtime/func/pi_perf/pi_perf.c           |  4 ++--
 testcases/realtime/func/prio-preempt/prio-preempt.c |  2 +-
 testcases/realtime/func/prio-wake/prio-wake.c       |  4 ++--
 .../pthread_kill_latency/pthread_kill_latency.c     |  4 ++--
 testcases/realtime/func/rt-migrate/rt-migrate.c     |  4 ++--
 testcases/realtime/func/sched_jitter/sched_jitter.c |  4 ++--
 .../realtime/func/sched_latency/sched_latency.c     |  4 ++--
 testcases/realtime/func/thread_clock/tc-2.c         |  2 +-
 testcases/realtime/lib/librttest.c                  |  4 ++--
 testcases/realtime/lib/libstats.c                   |  4 ++--
 .../realtime/perf/latency/pthread_cond_latency.c    |  2 +-
 testcases/realtime/perf/latency/pthread_cond_many.c |  4 ++--
 .../realtime/stress/pi-tests/lookup_pi_state.c      |  2 +-
 testcases/realtime/stress/pi-tests/testpi-3.c       |  2 +-
 37 files changed, 61 insertions(+), 61 deletions(-)

-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/6] configure: Print info about TI-RPC testsuite in summary

[Petr Vorel]

410ff69aa1 printed only info about libtirpc availability,
but whole TI-RPC can be disabled (it's enabled by default).
Print this in configure summary.

Fixes: 410ff69aa1 ("configure.ac: Print summary")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index 1f8796c874..3958e551c0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -447,6 +447,7 @@ cat << EOF
 TESTSUITES
 open posix testsuite: ${with_open_posix_testsuite:-no}
 realtime testsuite: ${with_realtime_testsuite:-no}
+TI-RPC testsuite: ${with_tirpc:-yes}
 
 LIBRARIES
 keyutils: ${have_keyutils:-yes}
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/6] configure: Don't assume testcases/realtime/configure.ac

[Petr Vorel]

a05298ec44 removed autotools configuration including
testcases/realtime/configure.ac. Running ./configure --with-realtime-testsuite
produces warning:

    === configuring in testcases/realtime (ltp/testcases/realtime)
    configure: WARNING: no configuration information is in testcases/realtime

Hence remove AC_CONFIG_SUBDIRS([testcases/realtime]).

Fixes: a05298ec44 ("testcases: realtime: Get rid of autotools")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 3958e551c0..8f8003f53b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -376,8 +376,6 @@ AC_ARG_WITH([realtime-testsuite],
 
 if test "x$with_realtime_testsuite" = xyes; then
     AC_SUBST([WITH_REALTIME_TESTSUITE],["yes"])
-    # Run configure on testcases/realtime as well.
-    AC_CONFIG_SUBDIRS([testcases/realtime])
 else
     AC_SUBST([WITH_REALTIME_TESTSUITE],["no"])
 fi
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 3/6] configure: Print info about KVM testsuite in summary

[Petr Vorel]

KVM testsuite cannot be disabled by user, it's disabled when missing
KVM linker script support. Yet it's useful to print this info in the
configure summary.

Fixes: 959146f954 ("configure: Check for KVM linker script support")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure.ac b/configure.ac
index 8f8003f53b..a8e40a5fc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -430,10 +430,12 @@ AC_LINK_IFELSE([AC_LANG_PROGRAM()],
   [
     AC_MSG_RESULT([yes])
     AC_SUBST([WITH_KVM_TESTSUITE],["yes"])
+    have_kvm=yes
   ],
   [
     AC_MSG_RESULT([no])
     AC_SUBST([WITH_KVM_TESTSUITE],["no"])
+    have_kvm=no
   ])
 _AC_LANG_PREFIX[]FLAGS="$ltp_backup_flags"
 LDFLAGS="$ltp_backup_ldflags"
@@ -443,6 +445,7 @@ AC_OUTPUT
 cat << EOF
 
 TESTSUITES
+KVM testsuite: $have_kvm
 open posix testsuite: ${with_open_posix_testsuite:-no}
 realtime testsuite: ${with_realtime_testsuite:-no}
 TI-RPC testsuite: ${with_tirpc:-yes}
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 4/6] configure: Enable realtime testsuite by default

[Petr Vorel]

This is needed because sched_football will be added to runtest/sched
as well.

Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac              | 7 +++++--
 include/mk/features.mk.in | 3 ---
 testcases/Makefile        | 4 ----
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index a8e40a5fc0..6fea710a05 100644
--- a/configure.ac
+++ b/configure.ac
@@ -369,7 +369,7 @@ fi
 # TODO: testcases/realtime requires bash and python.
 AC_ARG_WITH([realtime-testsuite],
   [AS_HELP_STRING([--with-realtime-testsuite],
-    [compile and install the realtime testsuite])],
+    [unused, kept for compatibility reason])],
   [with_realtime_testsuite=$withval],
   [with_realtime_testsuite=no]
 )
@@ -447,7 +447,6 @@ cat << EOF
 TESTSUITES
 KVM testsuite: $have_kvm
 open posix testsuite: ${with_open_posix_testsuite:-no}
-realtime testsuite: ${with_realtime_testsuite:-no}
 TI-RPC testsuite: ${with_tirpc:-yes}
 
 LIBRARIES
@@ -466,3 +465,7 @@ metadata generator: $with_metadata_generator
 HTML metadata: $with_metadata_html
 PDF metadata: $with_metadata_pdf
 EOF
+
+if test "x$with_realtime_testsuite" = xyes; then
+    AC_MSG_WARN([--with-realtime-testsuite has no effect and is kept for compatibilty reason. It will be removed in the future.])
+fi
diff --git a/include/mk/features.mk.in b/include/mk/features.mk.in
index 73a2f66587..2fc5230d49 100644
--- a/include/mk/features.mk.in
+++ b/include/mk/features.mk.in
@@ -39,8 +39,5 @@ WITH_METADATA_PDF		:= @WITH_METADATA_PDF@
 # Enable testcases/open_posix_testsuite's compile and install?
 WITH_OPEN_POSIX_TESTSUITE	:= @WITH_OPEN_POSIX_TESTSUITE@
 
-# Enable testcases/realtime's compile and install?
-WITH_REALTIME_TESTSUITE		:= @WITH_REALTIME_TESTSUITE@
-
 # Enable testcases/kernel/kvm compile and install?
 WITH_KVM_TESTSUITE		:= @WITH_KVM_TESTSUITE@
diff --git a/testcases/Makefile b/testcases/Makefile
index 662d4b1edd..d98d79f3c1 100644
--- a/testcases/Makefile
+++ b/testcases/Makefile
@@ -15,8 +15,4 @@ ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes)
 FILTER_OUT_DIRS		+= open_posix_testsuite
 endif
 
-ifneq ($(WITH_REALTIME_TESTSUITE),yes)
-FILTER_OUT_DIRS		+= realtime
-endif
-
 include $(top_srcdir)/include/mk/generic_trunk_target.mk
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Petr Vorel]

sched_football is useful not only for testing realtime,
therefore add it also to runtest/sched.

This depends on previous commit which enabled realtime by default.
We ignore the possibility realtime tests are disabled.

Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/sched | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/runtest/sched b/runtest/sched
index 5dab7a4c27..ecedd1a92b 100644
--- a/runtest/sched
+++ b/runtest/sched
@@ -18,3 +18,5 @@ sched_cli_serv run_sched_cliserv.sh
 sched_stress sched_stress.sh
 
 autogroup01 autogroup01
+
+sched_football sched_football
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 6/6] realtime: Use proper syntax for non-system include

[Petr Vorel]

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/realtime/func/async_handler/async_handler.c         | 4 ++--
 testcases/realtime/func/async_handler/async_handler_jk.c      | 4 ++--
 testcases/realtime/func/async_handler/async_handler_tsc.c     | 4 ++--
 testcases/realtime/func/gtod_latency/gtod_infinite.c          | 2 +-
 testcases/realtime/func/gtod_latency/gtod_latency.c           | 4 ++--
 testcases/realtime/func/hrtimer-prio/hrtimer-prio.c           | 4 ++--
 testcases/realtime/func/matrix_mult/matrix_mult.c             | 4 ++--
 testcases/realtime/func/measurement/preempt_timing.c          | 2 +-
 testcases/realtime/func/measurement/rdtsc-latency.c           | 2 +-
 testcases/realtime/func/periodic_cpu_load/periodic_cpu_load.c | 4 ++--
 .../func/periodic_cpu_load/periodic_cpu_load_single.c         | 4 ++--
 testcases/realtime/func/pi-tests/test-skeleton.c              | 2 +-
 testcases/realtime/func/pi-tests/testpi-0.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-1.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-2.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-4.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-5.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-6.c                   | 2 +-
 testcases/realtime/func/pi-tests/testpi-7.c                   | 2 +-
 testcases/realtime/func/pi_perf/pi_perf.c                     | 4 ++--
 testcases/realtime/func/prio-preempt/prio-preempt.c           | 2 +-
 testcases/realtime/func/prio-wake/prio-wake.c                 | 4 ++--
 .../realtime/func/pthread_kill_latency/pthread_kill_latency.c | 4 ++--
 testcases/realtime/func/rt-migrate/rt-migrate.c               | 4 ++--
 testcases/realtime/func/sched_jitter/sched_jitter.c           | 4 ++--
 testcases/realtime/func/sched_latency/sched_latency.c         | 4 ++--
 testcases/realtime/func/thread_clock/tc-2.c                   | 2 +-
 testcases/realtime/lib/librttest.c                            | 4 ++--
 testcases/realtime/lib/libstats.c                             | 4 ++--
 testcases/realtime/perf/latency/pthread_cond_latency.c        | 2 +-
 testcases/realtime/perf/latency/pthread_cond_many.c           | 4 ++--
 testcases/realtime/stress/pi-tests/lookup_pi_state.c          | 2 +-
 testcases/realtime/stress/pi-tests/testpi-3.c                 | 2 +-
 33 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/testcases/realtime/func/async_handler/async_handler.c b/testcases/realtime/func/async_handler/async_handler.c
index 70ef56cc1f..bbe1d9adc9 100644
--- a/testcases/realtime/func/async_handler/async_handler.c
+++ b/testcases/realtime/func/async_handler/async_handler.c
@@ -39,8 +39,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 #include <getopt.h>
 
 #define SIGNAL_PRIO 89
diff --git a/testcases/realtime/func/async_handler/async_handler_jk.c b/testcases/realtime/func/async_handler/async_handler_jk.c
index 4d87218224..8ce826b78a 100644
--- a/testcases/realtime/func/async_handler/async_handler_jk.c
+++ b/testcases/realtime/func/async_handler/async_handler_jk.c
@@ -41,8 +41,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 // This is the normal priority for an event handler if not specified.
 #define NORMAL_PRIORITY	43
diff --git a/testcases/realtime/func/async_handler/async_handler_tsc.c b/testcases/realtime/func/async_handler/async_handler_tsc.c
index 73d4ee5c61..0fe109c511 100644
--- a/testcases/realtime/func/async_handler/async_handler_tsc.c
+++ b/testcases/realtime/func/async_handler/async_handler_tsc.c
@@ -44,8 +44,8 @@
 #include <math.h>
 #include <stdint.h>
 #include <pthread.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #include "tst_tsc.h"
 
diff --git a/testcases/realtime/func/gtod_latency/gtod_infinite.c b/testcases/realtime/func/gtod_latency/gtod_infinite.c
index 676b132cbf..cee469bd46 100644
--- a/testcases/realtime/func/gtod_latency/gtod_infinite.c
+++ b/testcases/realtime/func/gtod_latency/gtod_infinite.c
@@ -50,7 +50,7 @@
 #include <stdlib.h>
 #include <time.h>
 #include <sched.h>
-#include <librttest.h>
+#include "librttest.h"
 #include <sys/mman.h>
 #include <unistd.h>
 #include <signal.h>
diff --git a/testcases/realtime/func/gtod_latency/gtod_latency.c b/testcases/realtime/func/gtod_latency/gtod_latency.c
index 26ee85f533..8f8174cd73 100644
--- a/testcases/realtime/func/gtod_latency/gtod_latency.c
+++ b/testcases/realtime/func/gtod_latency/gtod_latency.c
@@ -52,8 +52,8 @@
 #include <sched.h>
 #include <errno.h>
 #include <limits.h>
-#include <libstats.h>
-#include <librttest.h>
+#include "libstats.h"
+#include "librttest.h"
 #include <sys/mman.h>
 
 #define ITERATIONS 10000000
diff --git a/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c b/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
index cbc2343f61..5a382f5bd2 100644
--- a/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
+++ b/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
@@ -42,8 +42,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define DEF_MED_PRIO 60		// (softirqd-hrtimer,98)
 #define DEF_ITERATIONS 10000
diff --git a/testcases/realtime/func/matrix_mult/matrix_mult.c b/testcases/realtime/func/matrix_mult/matrix_mult.c
index c32092344d..e028952be8 100644
--- a/testcases/realtime/func/matrix_mult/matrix_mult.c
+++ b/testcases/realtime/func/matrix_mult/matrix_mult.c
@@ -16,8 +16,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define MAX_CPUS	8192
 #define PRIO		43
diff --git a/testcases/realtime/func/measurement/preempt_timing.c b/testcases/realtime/func/measurement/preempt_timing.c
index b84d546924..87286f63f2 100644
--- a/testcases/realtime/func/measurement/preempt_timing.c
+++ b/testcases/realtime/func/measurement/preempt_timing.c
@@ -51,7 +51,7 @@
 #include <errno.h>
 #include <sys/mman.h>
 #include <stdint.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #include "tst_tsc.h"
 
diff --git a/testcases/realtime/func/measurement/rdtsc-latency.c b/testcases/realtime/func/measurement/rdtsc-latency.c
index 3829947bc4..dba5a90f69 100644
--- a/testcases/realtime/func/measurement/rdtsc-latency.c
+++ b/testcases/realtime/func/measurement/rdtsc-latency.c
@@ -43,7 +43,7 @@
 #include <sched.h>
 #include <errno.h>
 #include <stdint.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #include "tst_tsc.h"
 
diff --git a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load.c b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load.c
index 9b9307a276..386eed98b4 100644
--- a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load.c
+++ b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load.c
@@ -38,8 +38,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define PRIO_A 63
 #define PRIO_B 53
diff --git a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
index ebbb461395..1e23d88391 100644
--- a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
+++ b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
@@ -38,8 +38,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define HIST_BUCKETS 100
 
diff --git a/testcases/realtime/func/pi-tests/test-skeleton.c b/testcases/realtime/func/pi-tests/test-skeleton.c
index 7816cf8771..816076e0cb 100644
--- a/testcases/realtime/func/pi-tests/test-skeleton.c
+++ b/testcases/realtime/func/pi-tests/test-skeleton.c
@@ -41,7 +41,7 @@
 #include <unistd.h>
 #include <sys/wait.h>
 #include <time.h>
-#include <librttest.h>
+#include "librttest.h"
 
 void usage(void)
 {
diff --git a/testcases/realtime/func/pi-tests/testpi-0.c b/testcases/realtime/func/pi-tests/testpi-0.c
index fd8ad0717d..093082382e 100644
--- a/testcases/realtime/func/pi-tests/testpi-0.c
+++ b/testcases/realtime/func/pi-tests/testpi-0.c
@@ -42,7 +42,7 @@
 #include <pthread.h>
 #include <sys/types.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 void usage(void)
 {
diff --git a/testcases/realtime/func/pi-tests/testpi-1.c b/testcases/realtime/func/pi-tests/testpi-1.c
index 3dbe292d25..8acf215ba9 100644
--- a/testcases/realtime/func/pi-tests/testpi-1.c
+++ b/testcases/realtime/func/pi-tests/testpi-1.c
@@ -44,7 +44,7 @@
 #include <sys/types.h>
 #include <sys/syscall.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 pthread_barrier_t barrier;
 
diff --git a/testcases/realtime/func/pi-tests/testpi-2.c b/testcases/realtime/func/pi-tests/testpi-2.c
index 3f7185e8d8..1752d0af9d 100644
--- a/testcases/realtime/func/pi-tests/testpi-2.c
+++ b/testcases/realtime/func/pi-tests/testpi-2.c
@@ -45,7 +45,7 @@
 #include <sys/types.h>
 #include <sys/syscall.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 pthread_barrier_t barrier;
 
diff --git a/testcases/realtime/func/pi-tests/testpi-4.c b/testcases/realtime/func/pi-tests/testpi-4.c
index e9e0ed6d6d..cb309e8bf7 100644
--- a/testcases/realtime/func/pi-tests/testpi-4.c
+++ b/testcases/realtime/func/pi-tests/testpi-4.c
@@ -45,7 +45,7 @@
 #include <sys/types.h>
 #include <sys/syscall.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 pthread_barrier_t barrier;
 
diff --git a/testcases/realtime/func/pi-tests/testpi-5.c b/testcases/realtime/func/pi-tests/testpi-5.c
index a524864174..24bbb334c1 100644
--- a/testcases/realtime/func/pi-tests/testpi-5.c
+++ b/testcases/realtime/func/pi-tests/testpi-5.c
@@ -39,7 +39,7 @@
 #include <pthread.h>
 #include <string.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 pthread_mutex_t child_mutex;
 
 void *child_thread(void *arg)
diff --git a/testcases/realtime/func/pi-tests/testpi-6.c b/testcases/realtime/func/pi-tests/testpi-6.c
index 637d38355c..d09e6d2dc5 100644
--- a/testcases/realtime/func/pi-tests/testpi-6.c
+++ b/testcases/realtime/func/pi-tests/testpi-6.c
@@ -39,7 +39,7 @@
 #include <pthread.h>
 #include <string.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 pthread_mutex_t child_mutex;
 
diff --git a/testcases/realtime/func/pi-tests/testpi-7.c b/testcases/realtime/func/pi-tests/testpi-7.c
index 20908b6621..499898775d 100644
--- a/testcases/realtime/func/pi-tests/testpi-7.c
+++ b/testcases/realtime/func/pi-tests/testpi-7.c
@@ -40,7 +40,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #define HIGH_PRIO 15
 #define MED_PRIO 10
diff --git a/testcases/realtime/func/pi_perf/pi_perf.c b/testcases/realtime/func/pi_perf/pi_perf.c
index 45cf8ed157..fa87839f62 100644
--- a/testcases/realtime/func/pi_perf/pi_perf.c
+++ b/testcases/realtime/func/pi_perf/pi_perf.c
@@ -47,8 +47,8 @@
 #include <unistd.h>
 #include <string.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define LOWPRIO 30
 #define HIGHPRIO 40
diff --git a/testcases/realtime/func/prio-preempt/prio-preempt.c b/testcases/realtime/func/prio-preempt/prio-preempt.c
index 16abc11846..2728337631 100644
--- a/testcases/realtime/func/prio-preempt/prio-preempt.c
+++ b/testcases/realtime/func/prio-preempt/prio-preempt.c
@@ -68,7 +68,7 @@
 #include <sched.h>
 #include <errno.h>
 #include <sys/syscall.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #define NUM_WORKERS	27
 #define CHECK_LIMIT	1
diff --git a/testcases/realtime/func/prio-wake/prio-wake.c b/testcases/realtime/func/prio-wake/prio-wake.c
index 8b3bee7b82..94eea0f41a 100644
--- a/testcases/realtime/func/prio-wake/prio-wake.c
+++ b/testcases/realtime/func/prio-wake/prio-wake.c
@@ -53,8 +53,8 @@
 #include <sched.h>
 #include <errno.h>
 #include <sys/syscall.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 volatile int running_threads = 0;
 static int rt_threads = 0;
diff --git a/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c b/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
index dc3dd3e81a..48cbffb873 100644
--- a/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
+++ b/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
@@ -51,8 +51,8 @@
 #include <sched.h>
 #include <signal.h>
 #include <errno.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define PRIO 89
 #define ITERATIONS 10000
diff --git a/testcases/realtime/func/rt-migrate/rt-migrate.c b/testcases/realtime/func/rt-migrate/rt-migrate.c
index 252e77e6a6..2a17628f44 100644
--- a/testcases/realtime/func/rt-migrate/rt-migrate.c
+++ b/testcases/realtime/func/rt-migrate/rt-migrate.c
@@ -67,8 +67,8 @@
 #include <errno.h>
 #include <sched.h>
 #include <pthread.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define gettid() syscall(__NR_gettid)
 
diff --git a/testcases/realtime/func/sched_jitter/sched_jitter.c b/testcases/realtime/func/sched_jitter/sched_jitter.c
index 9989528953..d1fba431b9 100644
--- a/testcases/realtime/func/sched_jitter/sched_jitter.c
+++ b/testcases/realtime/func/sched_jitter/sched_jitter.c
@@ -47,8 +47,8 @@
 #include <pthread.h>
 #include <sched.h>
 #include <unistd.h>
-#include <libstats.h>
-#include <librttest.h>
+#include "libstats.h"
+#include "librttest.h"
 
 #define NUMRUNS 1000
 #define NUMLOOPS 1000000
diff --git a/testcases/realtime/func/sched_latency/sched_latency.c b/testcases/realtime/func/sched_latency/sched_latency.c
index d19d5889a0..49d253b3c3 100644
--- a/testcases/realtime/func/sched_latency/sched_latency.c
+++ b/testcases/realtime/func/sched_latency/sched_latency.c
@@ -49,8 +49,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #define PRIO 89
 //#define PERIOD 17*NS_PER_MS
diff --git a/testcases/realtime/func/thread_clock/tc-2.c b/testcases/realtime/func/thread_clock/tc-2.c
index f994d40d61..323fbd1250 100644
--- a/testcases/realtime/func/thread_clock/tc-2.c
+++ b/testcases/realtime/func/thread_clock/tc-2.c
@@ -46,7 +46,7 @@
 #include <errno.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #define NS_PER_SEC 1000000000
 #define THRESHOLD 0.5		/* 500 milliseconds */
diff --git a/testcases/realtime/lib/librttest.c b/testcases/realtime/lib/librttest.c
index 7e81635efd..764398179d 100644
--- a/testcases/realtime/lib/librttest.c
+++ b/testcases/realtime/lib/librttest.c
@@ -40,8 +40,8 @@
  *
  *****************************************************************************/
 
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 
 #include <stdio.h>
 #include <stdlib.h>
diff --git a/testcases/realtime/lib/libstats.c b/testcases/realtime/lib/libstats.c
index 96090bd152..52b0cca6e8 100644
--- a/testcases/realtime/lib/libstats.c
+++ b/testcases/realtime/lib/libstats.c
@@ -43,8 +43,8 @@
 #include <errno.h>
 #include <unistd.h>
 #include <math.h>
-#include <libstats.h>
-#include <librttest.h>
+#include "libstats.h"
+#include "librttest.h"
 
 int save_stats = 0;
 
diff --git a/testcases/realtime/perf/latency/pthread_cond_latency.c b/testcases/realtime/perf/latency/pthread_cond_latency.c
index d0048d5e42..c1b64b20a1 100644
--- a/testcases/realtime/perf/latency/pthread_cond_latency.c
+++ b/testcases/realtime/perf/latency/pthread_cond_latency.c
@@ -41,7 +41,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 #include <stdlib.h>
-#include <librttest.h>
+#include "librttest.h"
 
 pthread_mutex_t child_mutex = PTHREAD_MUTEX_INITIALIZER;
 volatile int child_waiting = 0;
diff --git a/testcases/realtime/perf/latency/pthread_cond_many.c b/testcases/realtime/perf/latency/pthread_cond_many.c
index 9c6a897299..2bc9c1ed3b 100644
--- a/testcases/realtime/perf/latency/pthread_cond_many.c
+++ b/testcases/realtime/perf/latency/pthread_cond_many.c
@@ -44,8 +44,8 @@
 #include <sys/poll.h>
 #include <sys/types.h>
 #include <unistd.h>
-#include <librttest.h>
-#include <libstats.h>
+#include "librttest.h"
+#include "libstats.h"
 #define PASS_US 100
 pthread_mutex_t child_mutex;
 volatile int *child_waiting = NULL;
diff --git a/testcases/realtime/stress/pi-tests/lookup_pi_state.c b/testcases/realtime/stress/pi-tests/lookup_pi_state.c
index 83781d80e2..1799892aa6 100644
--- a/testcases/realtime/stress/pi-tests/lookup_pi_state.c
+++ b/testcases/realtime/stress/pi-tests/lookup_pi_state.c
@@ -34,7 +34,7 @@
  *****************************************************************************/
 
 #include <stdio.h>
-#include <librttest.h>
+#include "librttest.h"
 
 #define NUM_SLAVES 20
 #define SLAVE_PRIO 89
diff --git a/testcases/realtime/stress/pi-tests/testpi-3.c b/testcases/realtime/stress/pi-tests/testpi-3.c
index 1c3d44452c..70ec94513c 100644
--- a/testcases/realtime/stress/pi-tests/testpi-3.c
+++ b/testcases/realtime/stress/pi-tests/testpi-3.c
@@ -41,7 +41,7 @@
 #include <sys/types.h>
 #include <sys/syscall.h>
 #include <unistd.h>
-#include <librttest.h>
+#include "librttest.h"
 
 void usage(void)
 {
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup

[Cyril Hrubis]

Hi!
Whole patchset looks good.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup

[Li Wang]

For all:
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 0/6] sched_football in runtest/sched + configure cleanup

[Petr Vorel]

Hi all,

thanks for your review, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Petr Vorel]

Hi all,

> sched_football is useful not only for testing realtime,
> therefore add it also to runtest/sched.

> This depends on previous commit which enabled realtime by default.
> We ignore the possibility realtime tests are disabled.

> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  runtest/sched | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/runtest/sched b/runtest/sched
> index 5dab7a4c27..ecedd1a92b 100644
> --- a/runtest/sched
> +++ b/runtest/sched
> @@ -18,3 +18,5 @@ sched_cli_serv run_sched_cliserv.sh
>  sched_stress sched_stress.sh

>  autogroup01 autogroup01
> +
> +sched_football sched_football

I'm sorry, I haven't noticed, that realtime installs into a different directory:

cd ltp/testcases/realtime/func/sched_football
# make install
mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

Therefore scripts which expect it to have in the usual path $LTPROOT/testcases/bin
(e.g. /opt/ltp/testcases/bin) fail.

As temporary solution is to add $LTPROOT/testcases/realtime/func/sched_football/
to $PATH, for proper fix we have possibilities:

1) Either move sched_football.c out of realtime package (thus have some
duplicity, because it needs some of librealtime.a code),
2) or fully integrate realtime testsuite to LTP (e.g. convert librealtime.a to
normal LTP library in libs/ directory).
3) Change realtime make install target to install to $LTPROOT/testcases/bin and
ignore that some tests are not much useful for non-realtime kernels.

Just a reminder, to help which decision is better we have ticket for realtime
where is Mel Gorman's realtime usability investigation [1].

Because some time ago we planned to move tests to rt-tests testsuite [2] (we did
not consider to run them for non-realtime kernels, but recently Cyril saw
sched_football useful also for non-realtime kernels).

Do we plan to keep only sched_football in LTP or all tests? I suppose LTP should
only contains tests which are useful also for non-realtime kernels.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/issues/1078#issuecomment-2212913818
[2] https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Cyril Hrubis]

Hi!
> > diff --git a/runtest/sched b/runtest/sched
> > index 5dab7a4c27..ecedd1a92b 100644
> > --- a/runtest/sched
> > +++ b/runtest/sched
> > @@ -18,3 +18,5 @@ sched_cli_serv run_sched_cliserv.sh
> >  sched_stress sched_stress.sh
> 
> >  autogroup01 autogroup01
> > +
> > +sched_football sched_football
> 
> I'm sorry, I haven't noticed, that realtime installs into a different directory:

Uff, missed that as well. The INSTALL_DIR is set in the config.mk for
the realtime tests to $(srcdir) so it copies the layout of the realtime
directories.

> cd ltp/testcases/realtime/func/sched_football
> # make install
> mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
> install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
> install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

The minimal fix would be to overwrite the INSTALL_DIR for the
sched_football testcase, that would be:

diff --git a/testcases/realtime/func/sched_football/Makefile b/testcases/realtime/func/sched_football/Makefile
index 9bc779efa..aac98eab6 100644
--- a/testcases/realtime/func/sched_football/Makefile
+++ b/testcases/realtime/func/sched_football/Makefile
@@ -6,10 +6,11 @@

 top_srcdir             ?= ../../../..

-INSTALL_TARGETS                := run_auto.sh
 include $(top_srcdir)/include/mk/env_pre.mk
 include $(abs_srcdir)/../../config.mk

+INSTALL_DIR=testcases/bin
+
 # TODO: integrate properly with LTP library
 LDLIBS                 += -lltp
 include $(top_srcdir)/include/mk/generic_leaf_target.mk


We can move the source code around once we get to the realtime directory
cleanup later on.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Petr Vorel]

Hi all,

...
> > I'm sorry, I haven't noticed, that realtime installs into a different directory:

> Uff, missed that as well. The INSTALL_DIR is set in the config.mk for
> the realtime tests to $(srcdir) so it copies the layout of the realtime
> directories.

Thanks for having a look.

> > cd ltp/testcases/realtime/func/sched_football
> > # make install
> > mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
> > install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
> > install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

> The minimal fix would be to overwrite the INSTALL_DIR for the
> sched_football testcase, that would be:

> diff --git a/testcases/realtime/func/sched_football/Makefile b/testcases/realtime/func/sched_football/Makefile
> index 9bc779efa..aac98eab6 100644
> --- a/testcases/realtime/func/sched_football/Makefile
> +++ b/testcases/realtime/func/sched_football/Makefile
> @@ -6,10 +6,11 @@

>  top_srcdir             ?= ../../../..

> -INSTALL_TARGETS                := run_auto.sh
>  include $(top_srcdir)/include/mk/env_pre.mk
>  include $(abs_srcdir)/../../config.mk

> +INSTALL_DIR=testcases/bin
> +
>  # TODO: integrate properly with LTP library
>  LDLIBS                 += -lltp
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk

OK, quick fix. I'm for this to get problem fixed, but hope we sort realtime till
next release.

Thus 2 patches:
https://patchwork.ozlabs.org/project/ltp/list/?series=417019&state=*

Kind regards,
Petr

> We can move the source code around once we get to the realtime directory
> cleanup later on.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp