Re: [LTP] [PATCH 5/6] runtest/sched: Add sched_football

[Petr Vorel <pvorel@suse.cz>]

Hi all,

...
> > I'm sorry, I haven't noticed, that realtime installs into a different directory:

> Uff, missed that as well. The INSTALL_DIR is set in the config.mk for
> the realtime tests to $(srcdir) so it copies the layout of the realtime
> directories.

Thanks for having a look.

> > cd ltp/testcases/realtime/func/sched_football
> > # make install
> > mkdir -p "/opt/ltp/testcases/realtime/func/sched_football"
> > install -m 00775   "ltp/testcases/realtime/func/sched_football/run_auto.sh" /opt/ltp/testcases/realtime/func/sched_football/run_auto.sh
> > install -m 00775   "ltp/testcases/realtime/func/sched_football/sched_football" /opt/ltp/testcases/realtime/func/sched_football/sched_football

> The minimal fix would be to overwrite the INSTALL_DIR for the
> sched_football testcase, that would be:

> diff --git a/testcases/realtime/func/sched_football/Makefile b/testcases/realtime/func/sched_football/Makefile
> index 9bc779efa..aac98eab6 100644
> --- a/testcases/realtime/func/sched_football/Makefile
> +++ b/testcases/realtime/func/sched_football/Makefile
> @@ -6,10 +6,11 @@

>  top_srcdir             ?= ../../../..

> -INSTALL_TARGETS                := run_auto.sh
>  include $(top_srcdir)/include/mk/env_pre.mk
>  include $(abs_srcdir)/../../config.mk

> +INSTALL_DIR=testcases/bin
> +
>  # TODO: integrate properly with LTP library
>  LDLIBS                 += -lltp
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk

OK, quick fix. I'm for this to get problem fixed, but hope we sort realtime till
next release.

Thus 2 patches:
https://patchwork.ozlabs.org/project/ltp/list/?series=417019&state=*

Kind regards,
Petr

> We can move the source code around once we get to the realtime directory
> cleanup later on.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp