Re: [LTP] [PATCH v2 1/7] Add fallback definitions for lapi/fs.h

Li Wang
2024-07-26T12:04:18Z

On Thu, Jul 25, 2024 at 11:17 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > However, if we want LTP could be built with all the middle glibc
> versions
> > > (2.22 < glibc < 2.36)
> > > this might be thinking over. Because we announce support the minimal
> > > glibc-version is 2.22.
> >
> > Hm, it makes sense to keep it. But nobody will remember once we raise the
> > support.
>
> Maybe we should at least add a comment glibc-2.22 workaround or
> something that could be found with grep.
>

Sounds good.

> > Also, removing HAVE_LINUX_FS_H [1] works in the CI [2], including
> distros with
> > glibc 2.36 (minimal build [3] or all cross-compile builds, e.g. [4]).
> >
> > I wonder how realistic is that somebody is still affected by this issue.
>
> That's a good question but I'm afraid the only way to find out is to
> remove the workaround and wait for people complain that the next LTP
> release is broken...
>

I remember the broken was found by our CI automation tests
on Fedora-rawhide at that moment. That is a tentative version
and fixed imitatively by my patch, so yes, we can remove that
to see if it impacts other users.

--
Regards,
Li Wang