Re: [LTP] [PATCH 1/1] cachestat01: Reduce required space on 64kb page size

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

...
> > First I thought we should use tst_fs_has_free() in each
> > test_cached_pages() run, but test uses .all_filesystems, thus it's
> > always 300 MB. Should we, just in case, use .dev_min_size = 300,
> > to make sure it runs correctly even we change the DEV_SIZE_MB value?

> > Or, should we really calculate required space with tst_fs_has_free(),
> > based on page size num_pages and * 1.1 (reserved space for metadata)?

> Hmm, I guess that we should calculate how many pages are going to fit
> into the filesystem and cap it on a sane number as well, so that the
> test runs for a reasonable time if user passed a real and big block
> device, so something as:

> num_pages = MIN(tst_device->size/(2*page_size), 15);

Thanks! Sounds reasonable, I'll retest.

> >  testcases/kernel/syscalls/cachestat/cachestat01.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > diff --git a/testcases/kernel/syscalls/cachestat/cachestat01.c b/testcases/kernel/syscalls/cachestat/cachestat01.c
> > index f7f6275cbd..edb6335d9e 100644
> > --- a/testcases/kernel/syscalls/cachestat/cachestat01.c
> > +++ b/testcases/kernel/syscalls/cachestat/cachestat01.c
> > @@ -67,7 +67,7 @@ static void test_cached_pages(const unsigned int use_sync, const int num_pages)

> >  static void run(unsigned int use_sync)
> >  {
> > -	for (int i = 0; i < 15; i++)
> > +	for (int i = 0; i < page_size > 4096 ? 13 : 15; i++)

> Uff, this is starting to look like perl...

OK, using variable makes things readable.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp