From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F21CAC3DA49 for ; Fri, 2 Aug 2024 10:57:59 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 512F63D1F53 for ; Fri, 2 Aug 2024 12:57:58 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 817AC3D1F1D for ; Fri, 2 Aug 2024 12:57:43 +0200 (CEST) Authentication-Results: in-5.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id E410860157A for ; Fri, 2 Aug 2024 12:57:42 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1622F1FB9F; Fri, 2 Aug 2024 10:57:42 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E8E2D13999; Fri, 2 Aug 2024 10:57:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id trb5N6W7rGZXQgAAD6G6ig (envelope-from ); Fri, 02 Aug 2024 10:57:41 +0000 Date: Fri, 2 Aug 2024 12:57:39 +0200 From: Petr Vorel To: Andrea Cervesato Message-ID: <20240802105739.GA1622697@pevik> References: <20240802-fchmodat2-v5-0-bff2ec1a4f06@suse.com> <20240802-fchmodat2-v5-3-bff2ec1a4f06@suse.com> <20240802095503.GC1613449@pevik> <25cf4465-ce2b-4783-86be-b012e4d155d4@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <25cf4465-ce2b-4783-86be-b012e4d155d4@suse.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 1622F1FB9F X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.3 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v5 3/5] Add fchmodat2 fallback definition X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > Hi, > On 8/2/24 11:55, Petr Vorel wrote: > > Hi Andrea, > > > include/lapi/stat.h | 16 ++++++++++++++++ > > What is the reason this to be added to include/lapi/stat.h? > > It's not a general function? (otherwise tst_safe_macros.c would be more > > appropriate). > > And because one day it will be defined in ? > > Probably ok due both reasons, but I'm just curious, also because static inline > > brought various problems in the past. > I was asked by Cyril to use proper headers instead of safe macros headers, > which contain anything. Thanks for info, I'm sorry for the noise. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp