From: Petr Vorel <pvorel@suse.cz>
To: Ma Xinjian <maxj.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] cgroup_fj_common.sh: Do not disable systemd related cgroup subsystems
Date: Fri, 9 Aug 2024 10:45:27 +0200 [thread overview]
Message-ID: <20240809084527.GA337675@pevik> (raw)
In-Reply-To: <20240809073010.793324-1-maxj.fnst@fujitsu.com>
Hi Ma,
> The cpu, io, memory, and pids subsystems under the root cgroup cannot be disabled
> because they are used for systemd. Currently, the test of cpu and memory subsystems
> in cgroup_fj_function.sh and cgroup_fj_stress.sh will report the error
> "echo: write error: device or resource busy".
Could you please share a bit of info on which system it fails. Do you use cgroup v1?
Kind regards,
Petr
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> ---
> .../kernel/controllers/cgroup_fj/cgroup_fj_common.sh | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> index e866641ba..153d351d7 100755
> --- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> +++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> @@ -77,7 +77,13 @@ common_cleanup()
> cgroup_cleanup
> - [ "$cgroup_version" = "2" ] && ROD echo "-$subsystem" \> "/sys/fs/cgroup/cgroup.subtree_control"
> + if [ "$cgroup_version" = "2" ]; then
> + case "$subsystem" in
> + cpu|io|memory|pids)
> + :;;
> + *) ROD echo "-$subsystem" \> "/sys/fs/cgroup/cgroup.subtree_control";;
> + esac
> + fi
> }
> . cgroup_lib.sh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-08-09 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 7:30 [LTP] [PATCH v2] cgroup_fj_common.sh: Do not disable systemd related cgroup subsystems Ma Xinjian via ltp
2024-08-09 8:45 ` Petr Vorel [this message]
2024-08-09 8:52 ` Xinjian Ma (Fujitsu) via ltp
2024-08-09 10:31 ` Petr Vorel
2024-08-21 19:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809084527.GA337675@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=maxj.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox