Re: [LTP] [PATCH 1/1] pkey01: Fix TBROK due missing results

[Petr Vorel <pvorel@suse.cz>]

Hi Li, all,

> Hi Petr,

> On Fri, Aug 9, 2024 at 5:55 PM Petr Vorel <pvorel@suse.cz> wrote:

> > PKEY_DISABLE_EXECUTE is ppc64le specific test. Due messages being
> > TINFO test on other archs fails:

> >     tst_test.c:1498: TBROK: Test 2 haven't reported results!


> Ah yes, I think of why I used tst_brk in my previous patch.



> > Changing messages to TCONF. Also exit loop on !execute_supported TCONF
> > (no need to have 30x TCONF with the same error message, because we have
> > PKEY_DISABLE_EXECUTE last). The other TCONF (on MAP_HUGETLB) must be
> > repeated.


> Agreed.


> > Fixes: d2b8a476c2 ("pkey01: Adding test for PKEY_DISABLE_EXECUTE")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Hi Li, all,

> > if you don't like PKEY_DISABLE_EXECUTE having to be the last, we can
> > just have 30x TCONF (just to change both TINFO to TCONF). Whatever you
> > prefer.


> It's okay, I guess PKEY_DISABLE_EXECUTE is already the last feature
> for mem protection, READ, WRITE, EXEC, and I don't expect there will
> be a new permission to appear :).

Thanks for a quick ack, merged (with added comment for return value in the
code).

Kind regards,
Petr

> Feel free to add:
> Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp