* [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later
@ 2024-08-12 10:31 Jan Stancek
2024-08-12 12:02 ` Petr Vorel
2024-08-14 6:41 ` Li Wang
0 siblings, 2 replies; 5+ messages in thread
From: Jan Stancek @ 2024-08-12 10:31 UTC (permalink / raw)
To: ltp
The behaviour is allowed since commit:
2a010c412853 ("fs: don't block i_writecount during exec")
that landed in 6.11-rc1.
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
testcases/kernel/syscalls/creat/creat07.c | 10 ++++++++++
testcases/kernel/syscalls/execve/execve04.c | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/testcases/kernel/syscalls/creat/creat07.c b/testcases/kernel/syscalls/creat/creat07.c
index 7bd32ab4d328..f157e1a8fbb2 100644
--- a/testcases/kernel/syscalls/creat/creat07.c
+++ b/testcases/kernel/syscalls/creat/creat07.c
@@ -47,7 +47,17 @@ static void verify_creat(void)
SAFE_WAITPID(pid, NULL, 0);
}
+static void setup(void)
+{
+ if ((tst_kvercmp(6, 11, 0)) >= 0) {
+ tst_brk(TCONF, "Skipping test, write to executed file is "
+ "allowed since 6.11-rc1.\n"
+ "2a010c412853 (\"fs: don't block i_writecount during exec\")");
+ }
+}
+
static struct tst_test test = {
+ .setup = setup,
.test_all = verify_creat,
.needs_checkpoints = 1,
.forks_child = 1,
diff --git a/testcases/kernel/syscalls/execve/execve04.c b/testcases/kernel/syscalls/execve/execve04.c
index 3bac642e5412..7bbfece85906 100644
--- a/testcases/kernel/syscalls/execve/execve04.c
+++ b/testcases/kernel/syscalls/execve/execve04.c
@@ -65,7 +65,17 @@ static void do_child(void)
exit(0);
}
+static void setup(void)
+{
+ if ((tst_kvercmp(6, 11, 0)) >= 0) {
+ tst_brk(TCONF, "Skipping test, write to executed file is "
+ "allowed since 6.11-rc1.\n"
+ "2a010c412853 (\"fs: don't block i_writecount during exec\")");
+ }
+}
+
static struct tst_test test = {
+ .setup = setup,
.test_all = verify_execve,
.forks_child = 1,
.child_needs_reinit = 1,
--
2.43.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later
2024-08-12 10:31 [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later Jan Stancek
@ 2024-08-12 12:02 ` Petr Vorel
2024-08-12 13:31 ` Petr Vorel
2024-08-14 6:41 ` Li Wang
1 sibling, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2024-08-12 12:02 UTC (permalink / raw)
To: Jan Stancek
Cc: Linux Memory Management List, Christian Brauner,
kernel test robot, linux-kernel, ltp
Hi Jan,
> The behaviour is allowed since commit:
> 2a010c412853 ("fs: don't block i_writecount during exec")
> that landed in 6.11-rc1.
Thanks for noticing and fixing this!
It was reported some time ago:
https://lore.kernel.org/all/202406141431.2b72ca61-oliver.sang@intel.com/
https://lore.kernel.org/ltp/202407162117.7730986d-oliver.sang@intel.com/
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
> testcases/kernel/syscalls/creat/creat07.c | 10 ++++++++++
> testcases/kernel/syscalls/execve/execve04.c | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> diff --git a/testcases/kernel/syscalls/creat/creat07.c b/testcases/kernel/syscalls/creat/creat07.c
> index 7bd32ab4d328..f157e1a8fbb2 100644
> --- a/testcases/kernel/syscalls/creat/creat07.c
> +++ b/testcases/kernel/syscalls/creat/creat07.c
> @@ -47,7 +47,17 @@ static void verify_creat(void)
> SAFE_WAITPID(pid, NULL, 0);
> }
> +static void setup(void)
> +{
> + if ((tst_kvercmp(6, 11, 0)) >= 0) {
> + tst_brk(TCONF, "Skipping test, write to executed file is "
> + "allowed since 6.11-rc1.\n"
> + "2a010c412853 (\"fs: don't block i_writecount during exec\")");
> + }
> +}
> +
> static struct tst_test test = {
> + .setup = setup,
> .test_all = verify_creat,
> .needs_checkpoints = 1,
> .forks_child = 1,
> diff --git a/testcases/kernel/syscalls/execve/execve04.c b/testcases/kernel/syscalls/execve/execve04.c
> index 3bac642e5412..7bbfece85906 100644
> --- a/testcases/kernel/syscalls/execve/execve04.c
> +++ b/testcases/kernel/syscalls/execve/execve04.c
> @@ -65,7 +65,17 @@ static void do_child(void)
> exit(0);
> }
> +static void setup(void)
> +{
> + if ((tst_kvercmp(6, 11, 0)) >= 0) {
> + tst_brk(TCONF, "Skipping test, write to executed file is "
> + "allowed since 6.11-rc1.\n"
> + "2a010c412853 (\"fs: don't block i_writecount during exec\")");
> + }
> +}
> +
> static struct tst_test test = {
> + .setup = setup,
> .test_all = verify_execve,
> .forks_child = 1,
> .child_needs_reinit = 1,
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later
2024-08-12 12:02 ` Petr Vorel
@ 2024-08-12 13:31 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2024-08-12 13:31 UTC (permalink / raw)
To: Jan Stancek, ltp, Christian Brauner, linux-kernel,
Linux Memory Management List, kernel test robot
Hi Jan,
> Hi Jan,
> > The behaviour is allowed since commit:
> > 2a010c412853 ("fs: don't block i_writecount during exec")
> > that landed in 6.11-rc1.
> Thanks for noticing and fixing this!
> It was reported some time ago:
> https://lore.kernel.org/all/202406141431.2b72ca61-oliver.sang@intel.com/
> https://lore.kernel.org/ltp/202407162117.7730986d-oliver.sang@intel.com/
I have no idea, if you found it yourself, but let's give them the credit:
Reported-by: kernel test robot <oliver.sang@intel.com>
Kind regards,
Petr
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Kind regards,
> Petr
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
...
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later
2024-08-12 10:31 [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later Jan Stancek
2024-08-12 12:02 ` Petr Vorel
@ 2024-08-14 6:41 ` Li Wang
2024-08-14 6:45 ` Jan Stancek
1 sibling, 1 reply; 5+ messages in thread
From: Li Wang @ 2024-08-14 6:41 UTC (permalink / raw)
To: Jan Stancek; +Cc: ltp
On Mon, Aug 12, 2024 at 6:32 PM Jan Stancek <jstancek@redhat.com> wrote:
> The behaviour is allowed since commit:
> 2a010c412853 ("fs: don't block i_writecount during exec")
> that landed in 6.11-rc1.
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
Reviewed-by: Li Wang <liwang@redhat.com>
---
> testcases/kernel/syscalls/creat/creat07.c | 10 ++++++++++
> testcases/kernel/syscalls/execve/execve04.c | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/creat/creat07.c
> b/testcases/kernel/syscalls/creat/creat07.c
> index 7bd32ab4d328..f157e1a8fbb2 100644
> --- a/testcases/kernel/syscalls/creat/creat07.c
> +++ b/testcases/kernel/syscalls/creat/creat07.c
> @@ -47,7 +47,17 @@ static void verify_creat(void)
> SAFE_WAITPID(pid, NULL, 0);
> }
>
> +static void setup(void)
> +{
> + if ((tst_kvercmp(6, 11, 0)) >= 0) {
> + tst_brk(TCONF, "Skipping test, write to executed file is "
> + "allowed since 6.11-rc1.\n"
> + "2a010c412853 (\"fs: don't block i_writecount
> during exec\")");
> + }
> +}
> +
> static struct tst_test test = {
> + .setup = setup,
> .test_all = verify_creat,
> .needs_checkpoints = 1,
> .forks_child = 1,
> diff --git a/testcases/kernel/syscalls/execve/execve04.c
> b/testcases/kernel/syscalls/execve/execve04.c
> index 3bac642e5412..7bbfece85906 100644
> --- a/testcases/kernel/syscalls/execve/execve04.c
> +++ b/testcases/kernel/syscalls/execve/execve04.c
> @@ -65,7 +65,17 @@ static void do_child(void)
> exit(0);
> }
>
> +static void setup(void)
> +{
> + if ((tst_kvercmp(6, 11, 0)) >= 0) {
> + tst_brk(TCONF, "Skipping test, write to executed file is "
> + "allowed since 6.11-rc1.\n"
> + "2a010c412853 (\"fs: don't block i_writecount
> during exec\")");
> + }
> +}
> +
> static struct tst_test test = {
> + .setup = setup,
> .test_all = verify_execve,
> .forks_child = 1,
> .child_needs_reinit = 1,
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later
2024-08-14 6:41 ` Li Wang
@ 2024-08-14 6:45 ` Jan Stancek
0 siblings, 0 replies; 5+ messages in thread
From: Jan Stancek @ 2024-08-14 6:45 UTC (permalink / raw)
To: Li Wang; +Cc: ltp
On Wed, Aug 14, 2024 at 8:41 AM Li Wang <liwang@redhat.com> wrote:
>
>
>
> On Mon, Aug 12, 2024 at 6:32 PM Jan Stancek <jstancek@redhat.com> wrote:
>>
>> The behaviour is allowed since commit:
>> 2a010c412853 ("fs: don't block i_writecount during exec")
>> that landed in 6.11-rc1.
>>
>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
>
> Reviewed-by: Li Wang <liwang@redhat.com>
Pushed.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-14 6:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 10:31 [LTP] [PATCH] syscalls/execve04, creat07: skip for kernels 6.11 and later Jan Stancek
2024-08-12 12:02 ` Petr Vorel
2024-08-12 13:31 ` Petr Vorel
2024-08-14 6:41 ` Li Wang
2024-08-14 6:45 ` Jan Stancek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox