public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: calum.mackay@oracle.com, cel@kernel.org, chuck.lever@oracle.com,
	gregkh@linuxfoundation.org, jlayton@kernel.org,
	josef@toxicpanda.com, kernel-team@fb.com, ltp@lists.linux.it,
	pvorel@suse.cz, sherry.yang@oracle.com
Cc: stable-commits@vger.kernel.org
Subject: [LTP] Patch "nfsd: remove nfsd_stats, make th_cnt a global counter" has been added to the 6.1-stable tree
Date: Thu, 15 Aug 2024 10:39:58 +0200	[thread overview]
Message-ID: <2024081558-blend-geologist-4949@gregkh> (raw)
In-Reply-To: <20240810200009.9882-18-cel@kernel.org>


This is a note to let you know that I've just added the patch titled

    nfsd: remove nfsd_stats, make th_cnt a global counter

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     nfsd-remove-nfsd_stats-make-th_cnt-a-global-counter.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From stable+bounces-66338-greg=kroah.com@vger.kernel.org Sat Aug 10 22:01:30 2024
From: cel@kernel.org
Date: Sat, 10 Aug 2024 16:00:08 -0400
Subject: nfsd: remove nfsd_stats, make th_cnt a global counter
To: <stable@vger.kernel.org>
Cc: <linux-nfs@vger.kernel.org>, pvorel@suse.cz, sherry.yang@oracle.com, calum.mackay@oracle.com, kernel-team@fb.com, ltp@lists.linux.it, Josef Bacik <josef@toxicpanda.com>, Jeff Layton <jlayton@kernel.org>
Message-ID: <20240810200009.9882-18-cel@kernel.org>

From: Josef Bacik <josef@toxicpanda.com>

[ Upstream commit e41ee44cc6a473b1f414031782c3b4283d7f3e5f ]

This is the last global stat, take it out of the nfsd_stats struct and
make it a global part of nfsd, report it the same as always.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/nfsd/nfsd.h   |    1 +
 fs/nfsd/nfssvc.c |    5 +++--
 fs/nfsd/stats.c  |    3 +--
 fs/nfsd/stats.h  |    6 ------
 4 files changed, 5 insertions(+), 10 deletions(-)

--- a/fs/nfsd/nfsd.h
+++ b/fs/nfsd/nfsd.h
@@ -69,6 +69,7 @@ extern struct mutex		nfsd_mutex;
 extern spinlock_t		nfsd_drc_lock;
 extern unsigned long		nfsd_drc_max_mem;
 extern unsigned long		nfsd_drc_mem_used;
+extern atomic_t			nfsd_th_cnt;		/* number of available threads */
 
 extern const struct seq_operations nfs_exports_op;
 
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -34,6 +34,7 @@
 
 #define NFSDDBG_FACILITY	NFSDDBG_SVC
 
+atomic_t			nfsd_th_cnt = ATOMIC_INIT(0);
 extern struct svc_program	nfsd_program;
 static int			nfsd(void *vrqstp);
 #if defined(CONFIG_NFSD_V2_ACL) || defined(CONFIG_NFSD_V3_ACL)
@@ -955,7 +956,7 @@ nfsd(void *vrqstp)
 
 	current->fs->umask = 0;
 
-	atomic_inc(&nfsdstats.th_cnt);
+	atomic_inc(&nfsd_th_cnt);
 
 	set_freezable();
 
@@ -979,7 +980,7 @@ nfsd(void *vrqstp)
 		validate_process_creds();
 	}
 
-	atomic_dec(&nfsdstats.th_cnt);
+	atomic_dec(&nfsd_th_cnt);
 
 out:
 	/* Take an extra ref so that the svc_put in svc_exit_thread()
--- a/fs/nfsd/stats.c
+++ b/fs/nfsd/stats.c
@@ -27,7 +27,6 @@
 
 #include "nfsd.h"
 
-struct nfsd_stats	nfsdstats;
 struct svc_stat		nfsd_svcstats = {
 	.program	= &nfsd_program,
 };
@@ -47,7 +46,7 @@ static int nfsd_show(struct seq_file *se
 		   percpu_counter_sum_positive(&nn->counter[NFSD_STATS_IO_WRITE]));
 
 	/* thread usage: */
-	seq_printf(seq, "th %u 0", atomic_read(&nfsdstats.th_cnt));
+	seq_printf(seq, "th %u 0", atomic_read(&nfsd_th_cnt));
 
 	/* deprecated thread usage histogram stats */
 	for (i = 0; i < 10; i++)
--- a/fs/nfsd/stats.h
+++ b/fs/nfsd/stats.h
@@ -10,12 +10,6 @@
 #include <uapi/linux/nfsd/stats.h>
 #include <linux/percpu_counter.h>
 
-struct nfsd_stats {
-	atomic_t	th_cnt;		/* number of available threads */
-};
-
-extern struct nfsd_stats	nfsdstats;
-
 extern struct svc_stat		nfsd_svcstats;
 
 int nfsd_percpu_counters_init(struct percpu_counter *counters, int num);


Patches currently in stable-queue which might be from kroah.com@vger.kernel.org are

queue-6.1/nfsd-remove-nfsd_stats-make-th_cnt-a-global-counter.patch
queue-6.1/nfsd-move-reply-cache-initialization-into-nfsd-startup.patch
queue-6.1/sunrpc-remove-pg_stats-from-svc_program.patch
queue-6.1/mptcp-pm-don-t-try-to-create-sf-if-alloc-failed.patch
queue-6.1/nfsd-rename-nfsd_reply_cache_alloc.patch
queue-6.1/nfsd-make-all-of-the-nfsd-stats-per-network-namespace.patch
queue-6.1/mptcp-pass-addr-to-mptcp_pm_alloc_anno_list.patch
queue-6.1/nfsd-move-init-of-percpu-reply_cache_stats-counters-back-to-nfsd_init_net.patch
queue-6.1/nfsd-replace-nfsd_prune_bucket.patch
queue-6.1/nfsd-stop-setting-pg_stats-for-unused-stats.patch
queue-6.1/sunrpc-don-t-change-sv_stats-if-it-doesn-t-exist.patch
queue-6.1/nfsd-make-svc_stat-per-network-namespace-instead-of-global.patch
queue-6.1/nfsd-fix-frame-size-warning-in-svc_export_parse.patch
queue-6.1/nfsd-rename-nfsd_net_-to-nfsd_stats_.patch
queue-6.1/mptcp-pm-do-not-ignore-subflow-if-signal-flag-is-also-set.patch
queue-6.1/nfsd-refactor-nfsd_reply_cache_free_locked.patch
queue-6.1/mptcp-fully-established-after-add_addr-echo-on-mpj.patch
queue-6.1/sunrpc-use-the-struct-net-as-the-svc-proc-private.patch
queue-6.1/selftests-mptcp-join-test-both-signal-subflow.patch
queue-6.1/sunrpc-pass-in-the-sv_stats-struct-through-svc_create_pooled.patch
queue-6.1/mptcp-pm-reduce-indentation-blocks.patch
queue-6.1/nfsd-rewrite-synopsis-of-nfsd_percpu_counters_init.patch
queue-6.1/nfsd-expose-proc-net-sunrpc-nfsd-in-net-namespaces.patch
queue-6.1/nfsd-refactor-the-duplicate-reply-cache-shrinker.patch

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-08-15  8:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10 19:59 [LTP] [PATCH 6.1.y 00/18] Backport "make svc_stat per-net instead of global" cel
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 01/18] nfsd: move reply cache initialization into nfsd startup cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: move reply cache initialization into nfsd startup" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 02/18] nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_net cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_net" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 03/18] NFSD: Refactor nfsd_reply_cache_free_locked() cel
2024-08-15  8:39   ` [LTP] Patch "NFSD: Refactor nfsd_reply_cache_free_locked()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 04/18] NFSD: Rename nfsd_reply_cache_alloc() cel
2024-08-15  8:39   ` [LTP] Patch "NFSD: Rename nfsd_reply_cache_alloc()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 05/18] NFSD: Replace nfsd_prune_bucket() cel
2024-08-15  8:39   ` [LTP] Patch "NFSD: Replace nfsd_prune_bucket()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 06/18] NFSD: Refactor the duplicate reply cache shrinker cel
2024-08-15  8:39   ` [LTP] Patch "NFSD: Refactor the duplicate reply cache shrinker" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 07/18] NFSD: Rewrite synopsis of nfsd_percpu_counters_init() cel
2024-08-15  8:40   ` [LTP] Patch "NFSD: Rewrite synopsis of nfsd_percpu_counters_init()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [LTP] [PATCH 6.1.y 08/18] NFSD: Fix frame size warning in svc_export_parse() cel
2024-08-15  8:39   ` [LTP] Patch "NFSD: Fix frame size warning in svc_export_parse()" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 09/18] sunrpc: don't change ->sv_stats if it doesn't exist cel
2024-08-15  8:40   ` [LTP] Patch "sunrpc: don't change ->sv_stats if it doesn't exist" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 10/18] nfsd: stop setting ->pg_stats for unused stats cel
2024-08-15  8:40   ` [LTP] Patch "nfsd: stop setting ->pg_stats for unused stats" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 11/18] sunrpc: pass in the sv_stats struct through svc_create_pooled cel
2024-08-15  8:40   ` [LTP] Patch "sunrpc: pass in the sv_stats struct through svc_create_pooled" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 12/18] sunrpc: remove ->pg_stats from svc_program cel
2024-08-15  8:40   ` [LTP] Patch "sunrpc: remove ->pg_stats from svc_program" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 13/18] sunrpc: use the struct net as the svc proc private cel
2024-08-15  8:40   ` [LTP] Patch "sunrpc: use the struct net as the svc proc private" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 14/18] nfsd: rename NFSD_NET_* to NFSD_STATS_* cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: rename NFSD_NET_* to NFSD_STATS_*" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 15/18] nfsd: expose /proc/net/sunrpc/nfsd in net namespaces cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: expose /proc/net/sunrpc/nfsd in net namespaces" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 16/18] nfsd: make all of the nfsd stats per-network namespace cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: make all of the nfsd stats per-network namespace" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 17/18] nfsd: remove nfsd_stats, make th_cnt a global counter cel
2024-08-15  8:39   ` gregkh [this message]
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 18/18] nfsd: make svc_stat per-network namespace instead of global cel
2024-08-15  8:39   ` [LTP] Patch "nfsd: make svc_stat per-network namespace instead of global" has been added to the 6.1-stable tree gregkh
2024-08-12 11:34 ` [LTP] [PATCH 6.1.y 00/18] Backport "make svc_stat per-net instead of global" Sasha Levin
2024-08-12 13:52   ` Chuck Lever III via ltp
2024-08-12 14:02     ` Greg KH
2024-08-15  8:27 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024081558-blend-geologist-4949@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=calum.mackay@oracle.com \
    --cc=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=sherry.yang@oracle.com \
    --cc=stable-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox