[LTP] [PATCH v1] hugemmap11.c: Change NORMAL_PATH to current working directory

[LTP] [PATCH v1] hugemmap11.c: Change NORMAL_PATH to current working directory

[Wei Gao via ltp]

Following error will happen on sle-micro system since "/" is read only
tst_test.c:1062: TBROK: open(/ltp_hug9Iy6OR,16578,10247520240) failed: EROFS (30)

Signed-off-by: Wei Gao <wegao@suse.com>
---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
index 496a814b5..67fca2ddf 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
@@ -23,7 +23,7 @@
 
 #define P0 "ffffffff"
 #define IOSZ 4096
-#define NORMAL_PATH ""
+#define NORMAL_PATH "./"
 #define MNTPOINT "hugetlbfs/"
 
 static long hpage_size;
-- 
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] hugemmap11.c: Change NORMAL_PATH to current working directory

[Petr Vorel]

Hi Wei, Li,

> Following error will happen on sle-micro system since "/" is read only
> tst_test.c:1062: TBROK: open(/ltp_hug9Iy6OR,16578,10247520240) failed: EROFS (30)

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> index 496a814b5..67fca2ddf 100644
> --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> @@ -23,7 +23,7 @@

>  #define P0 "ffffffff"
>  #define IOSZ 4096
> -#define NORMAL_PATH ""
> +#define NORMAL_PATH "./"

Reviewed-by: Petr Vorel <pvorel@suse.cz>

@Li: Do you see any consequences?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] hugemmap11.c: Change NORMAL_PATH to current working directory

[Li Wang]

On Mon, Sep 2, 2024 at 3:29 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Wei, Li,
>
> > Following error will happen on sle-micro system since "/" is read only
> > tst_test.c:1062: TBROK: open(/ltp_hug9Iy6OR,16578,10247520240) failed: EROFS (30)
>
> > Signed-off-by: Wei Gao <wegao@suse.com>
> > ---
> >  testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> > index 496a814b5..67fca2ddf 100644
> > --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> > +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap11.c
> > @@ -23,7 +23,7 @@
>
> >  #define P0 "ffffffff"
> >  #define IOSZ 4096
> > -#define NORMAL_PATH ""
> > +#define NORMAL_PATH "./"
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> @Li: Do you see any consequences?

I think it is no problem to apply the patch, as you pointed
mntpoint implies needs_tmpdir.  So it won't hit an unwritable
issue when using $PWD.

Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] hugemmap11.c: Change NORMAL_PATH to current working directory

[Petr Vorel]

Hi Wei, Li,

...
> > @Li: Do you see any consequences?

> I think it is no problem to apply the patch, as you pointed
> mntpoint implies needs_tmpdir.  So it won't hit an unwritable
> issue when using $PWD.

Li, thanks a lot for double check!
Wei, thanks for fixing this.
Merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp