From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] mpls01.sh: Add --allow-unsupported for modprobe
Date: Wed, 4 Sep 2024 06:47:10 +0200 [thread overview]
Message-ID: <20240904044710.GA834275@pevik> (raw)
In-Reply-To: <20240904035808.5891-1-wegao@suse.com>
Hi Wei,
I suggest these changes:
1) use mpls_setup_driver also in mpls_setup()
- replace tst_net_run(). I don't understand why you did not do it in the
patchset (I suggested that), but I can replace it during merge.
2) update the commit message: s/mpls01.sh/mpls01/
(fixing all mpls tests)
With that:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
+++ testcases/network/mpls/mpls_lib.sh
@@ -47,7 +47,7 @@ mpls_setup()
{
local label="$1"
- tst_net_run -s "modprobe -a $TST_NEEDS_DRIVERS"
+ mpls_setup_driver
ROD sysctl -q net.mpls.conf.$(tst_iface).input=1
tst_set_sysctl net.mpls.conf.lo.input 1 safe
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-09-04 4:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 9:57 [LTP] [PATCH v1] mpls01.sh: Add --allow-unsupported for modprobe Wei Gao via ltp
2024-08-30 10:38 ` Petr Vorel
2024-09-02 10:39 ` Cyril Hrubis
2024-09-02 11:00 ` Petr Vorel
2024-09-02 2:40 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-09-02 11:02 ` Petr Vorel
2024-09-03 8:19 ` [LTP] [PATCH v3] " Wei Gao via ltp
2024-09-03 9:49 ` Petr Vorel
2024-09-03 10:16 ` Cyril Hrubis
2024-09-03 11:26 ` Petr Vorel
2024-09-04 3:58 ` [LTP] [PATCH v4] " Wei Gao via ltp
2024-09-04 4:47 ` Petr Vorel [this message]
2024-09-04 6:50 ` Wei Gao via ltp
2024-09-04 6:48 ` [LTP] [PATCH v5] " Wei Gao via ltp
2024-09-04 6:56 ` [LTP] [PATCH v6] mpls01: Add --allow-unsupported for modprobe(fixing all mpls cases) Wei Gao via ltp
2024-09-05 5:12 ` Petr Vorel
2024-09-05 8:47 ` Cyril Hrubis
2024-09-05 12:02 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904044710.GA834275@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox