From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it, automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [PATCH] Remove now unsupported power management tests
Date: Tue, 15 Oct 2024 17:45:35 +0200 [thread overview]
Message-ID: <20241015154535.GA31165@pevik> (raw)
In-Reply-To: <20240916113308.16749-1-chrubis@suse.cz>
Hi Cyril,
[ Cc automated-testing@lists.yoctoproject.org ]
> The sched_mc_power_savings and sched_smt_power_savings sysfs knobs
> were removed from kernel in:
> commit 8e7fbcbc22c12414bcc9dfdd683637f58fb32759
> Author: Peter Zijlstra <peterz@infradead.org>
> Date: Mon Jan 9 11:28:35 2012 +0100
> sched: Remove stale power aware scheduling remnants and dysfunctional knobs
> That went into kernel 3.5 and the minimal kernel version LTP currently
> supports is 3.10.
Good catch.
I wanted to be happy that whole power management testsuite is being removed
(legacy unmaintained code written in python which is not preferred language for
LTP). But it's really just the unsupported subset. Otherwise
power_management_tests would need to be removed from scenario_groups/default.
> This has been discussed in:
> https://github.com/linux-test-project/ltp/pull/1016
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
> runtest/power_management_tests | 3 -
> runtest/power_management_tests_exclusive | 6 -
> testcases/kernel/power_management/.gitignore | 1 -
> testcases/kernel/power_management/README | 29 ----
> .../power_management/pm_cpu_consolidation.py | 143 ------------------
> .../power_management/pm_get_sched_values.c | 36 -----
> .../kernel/power_management/runpwtests01.sh | 71 ---------
> .../kernel/power_management/runpwtests02.sh | 68 ---------
> .../kernel/power_management/runpwtests05.sh | 76 ----------
Deleted runpwtests05.sh was the only file which used pm_sched_domain.py
and pm_ilb_test.py.
And when these python scripts are deleted, there is still some dead
code in testcases/kernel/power_management/lib/pm_sched_mc.py which works with
sched_mc_power_savings: reset_schedmc() and set_sched_mc_power()
and with set_sched_smt_power: set_sched_smt_power() and reset_schedsmt().
Could you please delete these. With this:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-10-15 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 11:33 [LTP] [PATCH] Remove now unsupported power management tests Cyril Hrubis
2024-10-15 15:45 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015154535.GA31165@pevik \
--to=pvorel@suse.cz \
--cc=automated-testing@lists.yoctoproject.org \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox