From: Petr Vorel <pvorel@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: yangerkun@huawei.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] fanotify10: Calling drop_cache three times to ensure the inode is evicted
Date: Fri, 18 Oct 2024 19:18:02 +0200 [thread overview]
Message-ID: <20241018171802.GA333901@pevik> (raw)
In-Reply-To: <20241018115224.jsz3rrnqpx5mwhze@quack3>
Hi Jan, Zizhi Wo,
...
> > NUMA0: parent inode exist exist free
> > NUMA1: parent dentry exist free free
> > NUMA2: child inode exist free free
> > NUMA3: child dentry free free free
> Well, this is right but there's also the while ((freed >> shift++) > 1)
> loop in drop_slab() which should generally make us loop as long as there's
> something to reclaim. But yes, if in theory the only thing we can reclaim
> is the child dentry in the first round, then what you suggest may happen.
> > Due to the release of the dependency chain, the drop_cache cleanup also
> > takes several times. Therefore, to be safe, three drop_cache operations are
> > needed to handle the two-level directory structure.
> OK, I'm willing to give this one last try. If it doesn't work out, I'd just
> drop these tests until we can find a more reliable way of testing this.
> Feel free to add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks you both for yet another fix and review, both is very much appreciated.
Hopefully this will finally work.
Kind regards,
Petr
> Honza
...
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-10-18 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 7:13 [LTP] [PATCH] fanotify10: Calling drop_cache three times to ensure the inode is evicted Zizhi Wo via ltp
2024-10-18 11:52 ` Jan Kara
2024-10-18 17:18 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018171802.GA333901@pevik \
--to=pvorel@suse.cz \
--cc=jack@suse.cz \
--cc=ltp@lists.linux.it \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox