public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 2/3] Add script to generate arch(s) dependant syscalls
Date: Wed, 30 Oct 2024 16:15:13 +0100	[thread overview]
Message-ID: <20241030151513.GA915069@pevik> (raw)
In-Reply-To: <20241030-generate_syscalls-v5-2-eed6a87dc787@suse.com>

Hi Andrea,


> From: Andrea Cervesato <andrea.cervesato@suse.com>

> Add generate_arch.sh script which can be used to generate arch(s)
> dependant syscalls file. The way it works is pretty simple: for each
> architecture defined into supported-arch.txt, compile kernel headers,
> extract the list of syscalls and generate a .in file containing all of
> them, associated with their own syscall's number.
> The way syscalls files are generated, passes through a C application
> which is automatically checking the availability of the syscalls in
> the user space environment.

Thanks for this!

...
> --- /dev/null
> +++ b/include/lapi/syscalls/generate_arch.sh
> @@ -0,0 +1,211 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# This is an adaptation of the update-tables.sh script, included in the
> +# syscalls-table project (https://github.com/hrw/syscalls-table) and released
> +# under the MIT license.
I was surprised you use shell instead of python, but I see the original author
also use shell [1]. I wish he would have used python for this part, but good
that you reuse what was available.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
> +++ b/include/lapi/syscalls/supported-arch.txt
> @@ -1,13 +1,13 @@
> -aarch64
>  arc
> +arm64
>  arm
> -hppa
>  i386
>  ia64
> -loongarch
> -mips_n32
> -mips_n64
> -mips_o32
> +loongarch64
> +mips64n32
> +mips64
> +mipso32
> +parisc
>  powerpc64
>  powerpc
>  s390x

Interesting enough how many archs the original project supports [2], which makes
sense for it as he products HTML table as reference [3].

Kind regards,
Petr

[1] https://github.com/hrw/syscalls-table/blob/master/scripts/update-tables.sh
[2] https://github.com/hrw/syscalls-table/blob/master/system_calls/architectures_in_kernel.py
[3] https://gpages.juszkiewicz.com.pl/syscalls-table/syscalls.html

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-10-30 15:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:52 [LTP] [PATCH v5 0/3] Automatically generate syscalls.h Andrea Cervesato
2024-10-30  8:53 ` [LTP] [PATCH v5 1/3] Refactor regen.sh script to generate syscalls Andrea Cervesato
2024-10-30 13:47   ` Cyril Hrubis
2024-10-30 14:20     ` Andrea Cervesato via ltp
2024-10-30 17:43       ` Cyril Hrubis
2024-10-30 14:49   ` Petr Vorel
2024-10-30 15:34     ` Andrea Cervesato via ltp
2024-10-30 16:49       ` Petr Vorel
2024-10-30  8:53 ` [LTP] [PATCH v5 2/3] Add script to generate arch(s) dependant syscalls Andrea Cervesato
2024-10-30 14:04   ` Cyril Hrubis
2024-10-30 15:15   ` Petr Vorel [this message]
2024-10-30 15:24     ` Andrea Cervesato via ltp
2024-10-30  8:53 ` [LTP] [PATCH v5 3/3] Delete obsolete strip_syscall.awk file Andrea Cervesato
2024-10-30 14:04   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030151513.GA915069@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox