Re: [LTP] [PATCH v7 1/4] Refactor regen.sh script to generate syscalls

Petr Vorel
2024-10-31T13:01:39Z

Hi Andrea,

> --- /dev/null
> +++ b/include/lapi/syscalls/generate_syscalls.sh
> @@ -0,0 +1,109 @@
> +#!/bin/sh -eux

I'm very sorry, I asked for "#!/bin/sh -eux", but better would be without "x".
"x" prints output of the commands which is too verbose on generate_syscalls.sh.
Could you please, when you merge, change it to "#!/bin/sh -eu"?
I'm not sure if it should stay in the other script.
This is on dash, but I suppose this can be reproducible on bash as well.

$ ./configure
...
+ syscall_nr=__NR_writev
+ echo # ifndef __NR_writev
+ echo # define __NR_writev __LTP__NR_INVALID_SYSCALL
+ echo # endif
+ echo #endif

$ ./configure > /tmp/out 2> /tmp/err; wc -l /tmp/out /tmp/err

on master:
290 /tmp/out
3 /tmp/err
293 total

on v7 (at least what I apply from https://patchwork.ozlabs.org/series/430633/mbox/):
289 /tmp/out
48706 /tmp/err
48995 total

Kind regards,
Petr