From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v9 5/5] Add documentation about syscalls.h generator
Date: Mon, 4 Nov 2024 09:17:00 +0100 [thread overview]
Message-ID: <20241104081700.GB1376811@pevik> (raw)
In-Reply-To: <20241101-generate_syscalls-v9-5-d2c3820b0323@suse.com>
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, thanks!
> diff --git a/doc/developers/test_case_tutorial.rst b/doc/developers/test_case_tutorial.rst
> index be9a0ea8bac1d690b4ed4879d110f87c3f2a381a..97f385e5853a9041ac3e5ded7fb99e8355d84742 100644
> --- a/doc/developers/test_case_tutorial.rst
> +++ b/doc/developers/test_case_tutorial.rst
> @@ -302,24 +302,27 @@ for a distribution's C library version to be older than its kernel or it may use
> cut down C library in comparison to the GNU one. So we must call ``statx()``
> using the general ``syscall()`` interface.
> -The LTP contains a library for dealing with the ``syscall`` interface, which is
> +LTP contains a library for dealing with the ``syscall`` interface, which is
very nit: This was added by Richie in 7324ee19de. I also think that the "The"
article should not be there, but I'm surprised that he would make a make a mistake
(native speaker).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-11-04 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 10:48 [LTP] [PATCH v9 0/5] Automatically generate syscalls.h Andrea Cervesato
2024-11-01 10:48 ` [LTP] [PATCH v9 1/5] Refactor regen.sh script to generate syscalls Andrea Cervesato
2024-11-01 10:48 ` [LTP] [PATCH v9 2/5] Add script to generate arch(s) dependant syscalls Andrea Cervesato
2024-11-01 11:30 ` Petr Vorel
2024-11-01 13:23 ` Andrea Cervesato via ltp
2024-11-01 17:02 ` Petr Vorel
2024-11-01 10:48 ` [LTP] [PATCH v9 3/5] Update arch(s) syscalls files Andrea Cervesato
2024-11-04 8:05 ` Petr Vorel
2024-11-04 11:12 ` Cyril Hrubis
2024-11-01 10:48 ` [LTP] [PATCH v9 4/5] Delete obsolete strip_syscall.awk file Andrea Cervesato
2024-11-01 10:48 ` [LTP] [PATCH v9 5/5] Add documentation about syscalls.h generator Andrea Cervesato
2024-11-04 8:17 ` Petr Vorel [this message]
2024-11-04 12:25 ` Cyril Hrubis
2024-11-05 8:55 ` [LTP] [PATCH v9 0/5] Automatically generate syscalls.h Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104081700.GB1376811@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox