From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6E68D597A7 for ; Tue, 12 Nov 2024 21:23:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A97453D629E for ; Tue, 12 Nov 2024 22:23:27 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id F3B7F3D629E for ; Tue, 12 Nov 2024 22:23:11 +0100 (CET) Authentication-Results: in-4.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 38E5B1031A2B for ; Tue, 12 Nov 2024 22:23:09 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AC99E2122E; Tue, 12 Nov 2024 21:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731446588; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2mePtlrtkoWa1jGBFQ+09rqvn+dVGXlp1JLKbVtmFgg=; b=tmHbZ5yvoNvNON98FxHjgC81dGnEykZgh1eRU7E0ndmmdYbjZMdo/MsZVwGq2n3sa+Xvmr /V/rjSHCqe9FaM31fa34JWENa6pCZKPzFqTy9MVQ/l0i19JaeZqSBJQHj+w00NVWuMVgYm utDhM5CL8e5S6IsovnMpHc9lvzBmd2M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731446588; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2mePtlrtkoWa1jGBFQ+09rqvn+dVGXlp1JLKbVtmFgg=; b=68TgywcoWRW6ovPz7EuqanpoSdairQD3x85V1p0+L0UdFcVUSbjkeeOPD2A+zLxe9+CU3H P3FSDk0IKMxdiKCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tmHbZ5yv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=68Tgywco DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731446588; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2mePtlrtkoWa1jGBFQ+09rqvn+dVGXlp1JLKbVtmFgg=; b=tmHbZ5yvoNvNON98FxHjgC81dGnEykZgh1eRU7E0ndmmdYbjZMdo/MsZVwGq2n3sa+Xvmr /V/rjSHCqe9FaM31fa34JWENa6pCZKPzFqTy9MVQ/l0i19JaeZqSBJQHj+w00NVWuMVgYm utDhM5CL8e5S6IsovnMpHc9lvzBmd2M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731446588; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2mePtlrtkoWa1jGBFQ+09rqvn+dVGXlp1JLKbVtmFgg=; b=68TgywcoWRW6ovPz7EuqanpoSdairQD3x85V1p0+L0UdFcVUSbjkeeOPD2A+zLxe9+CU3H P3FSDk0IKMxdiKCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0785313721; Tue, 12 Nov 2024 21:23:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BWc/OzvHM2clcQAAD6G6ig (envelope-from ); Tue, 12 Nov 2024 21:23:07 +0000 Date: Tue, 12 Nov 2024 22:23:02 +0100 From: Petr Vorel To: Cyril Hrubis , Martin Doucha , ltp@lists.linux.it Message-ID: <20241112212302.GA234224@pevik> References: <20241101141111.104803-1-mdoucha@suse.cz> <20241101141111.104803-6-mdoucha@suse.cz> <20241101233221.GC1324664@pevik> <20241104155947.GC1388681@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241104155947.GC1388681@pevik> X-Rspamd-Queue-Id: AC99E2122E X-Spamd-Result: default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_THREE(0.00)[3]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 5/5] Add test for data integrity over NFS X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > > Hi! > > > I'm looking at the nfs_lib.sh, we do have a lot there actually since it > > > runs for all filesystems and we run the nfs tests for different nfs > > > versions as well. This does not seem that would integrate well into the > > > tst_test all_filesystems testing. > Yes (found that as well when replied to your first email). > I thought you want to integrate NFS just for a shake of other tests, which use > .all_filesystems (e.g. some NFS to be added into fs_type_whitelist[], e.g. > "nfsv4), which would of course require u specific setup. > That would, of course did not cover all range of NFS versions + also using UDP, > which is used for current NFS tests (including this one). > > > I will think a bit how to integrate things better, because having LTP > > > test inside LTP test will never work well. > Reviewed-by: Petr Vorel > Tested-by: Petr Vorel > Looks usable + later on tests which use netstress.c could be converted to use it > as well. @Cyril: gently ping, could you please merge the patch you posted below? Obviously usable test + example which can be used for network tests. Kind regards, Petr > Kind regards, > Petr > > So one posibility is to use the new shell test library that integrates > > cleanly with C, then we can have a shell nfs test that runs for all > > filesystems, mounts the nfs and then runs the C fsplough itself. > > Minimal example how to do that is: > > From b48184d4fa1918afe6c84d0e691f8d46c986e92c Mon Sep 17 00:00:00 2001 > > From: Cyril Hrubis > > Date: Mon, 4 Nov 2024 14:29:24 +0100 > > Subject: [PATCH] shell lib: Add example how to run C child > > Signed-off-by: Cyril Hrubis > > --- > > testcases/lib/run_tests.sh | 2 +- > > testcases/lib/tests/.gitignore | 1 + > > testcases/lib/tests/shell_c_child.c | 16 ++++++++++++++ > > testcases/lib/tests/shell_loader_c_child.sh | 24 +++++++++++++++++++++ > > 4 files changed, 42 insertions(+), 1 deletion(-) > > create mode 100644 testcases/lib/tests/shell_c_child.c > > create mode 100755 testcases/lib/tests/shell_loader_c_child.sh > > diff --git a/testcases/lib/run_tests.sh b/testcases/lib/run_tests.sh > > index 8ea615f96..40d415e6c 100755 > > --- a/testcases/lib/run_tests.sh > > +++ b/testcases/lib/run_tests.sh > > @@ -14,7 +14,7 @@ for i in shell_loader.sh shell_loader_all_filesystems.sh shell_loader_no_metadat > > shell_loader_wrong_metadata.sh shell_loader_invalid_metadata.sh\ > > shell_loader_supported_archs.sh shell_loader_filesystems.sh\ > > shell_loader_tcnt.sh shell_loader_kconfigs.sh shell_loader_tags.sh \ > > - shell_loader_invalid_block.sh; do > > + shell_loader_invalid_block.sh shell_loader_c_child.sh; do > > echo > > echo "*** Running $i ***" > > echo > > diff --git a/testcases/lib/tests/.gitignore b/testcases/lib/tests/.gitignore > > index da967c4d6..e9e163d13 100644 > > --- a/testcases/lib/tests/.gitignore > > +++ b/testcases/lib/tests/.gitignore > > @@ -4,3 +4,4 @@ shell_test03 > > shell_test04 > > shell_test05 > > shell_test06 > > +shell_c_child > > diff --git a/testcases/lib/tests/shell_c_child.c b/testcases/lib/tests/shell_c_child.c > > new file mode 100644 > > index 000000000..fda5133a6 > > --- /dev/null > > +++ b/testcases/lib/tests/shell_c_child.c > > @@ -0,0 +1,16 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > +/* > > + * Shell test C child example. > > + */ > > + > > +#define TST_NO_DEFAULT_MAIN > > +#include "tst_test.h" > > + > > +int main(void) > > +{ > > + tst_reinit(); > > + > > + tst_res(TPASS, "C child works fine!"); > > + > > + return 0; > > +} > > diff --git a/testcases/lib/tests/shell_loader_c_child.sh b/testcases/lib/tests/shell_loader_c_child.sh > > new file mode 100755 > > index 000000000..d190be6e2 > > --- /dev/null > > +++ b/testcases/lib/tests/shell_loader_c_child.sh > > @@ -0,0 +1,24 @@ > > +#!/bin/sh > > +# > > +# --- > > +# doc > > +# > > +# [Description] > > +# > > +# This is an example how to run C child from shell. > > +# --- > > +# > > +# --- > > +# env > > +# { > > +# } > > +# --- > > + > > +. tst_loader.sh > > + > > +if [ -n "LTP_IPC_PATH" ]; then > > + tst_res TPASS "LTP_IPC_PATH=$LTP_IPC_PATH!" > > +fi > > + > > +tst_res TINFO "Running C child" > > +shell_c_child -- Mailing list info: https://lists.linux.it/listinfo/ltp