public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 5/5] Add test for data integrity over NFS
Date: Tue, 12 Nov 2024 22:40:15 +0100	[thread overview]
Message-ID: <20241112214015.GA235246@pevik> (raw)
In-Reply-To: <e4209eb0-1d9c-4908-948f-3e2f987cc79e@suse.cz>

> On 02. 11. 24 0:32, Petr Vorel wrote:
> > Hi Martin,

> > BTW I got timeout when testing nfs10.sh -v 4 -t tcp on Tumbleweed VM (2 CPU,
> > 1.4 GB RAM, 2 GB SWAP) on my laptop:
> > ...

> > The quickest way would be to use the same calculation (* $TST_CNT + 5% for spare
> > time) in nfs10.sh and increase tst_set_timeout with.

> Yes, that is expected for now, we need to add separate timeouts for each
> subtest, including per-filesystem.

Right, I suppose you post v2.

I wonder why you did not get timeouts on your laptop. I suppose calculation for
fsplough was below 5 min, right?

> > Or, I wonder if using tst_loader.sh and tst_run_shell.c would help to integrate
> > these. But I'm not sure how easily could be nfs_lib.sh integrated, e.g.
> > * isn't it too late, when it uses tst_net.sh (maybe this file would need to be
> >    integrated)
> > * should use keep using TST_ALL_FILESYSTEMS=1 from tst_test.sh or configure
> >    via all_filesystems=1 via json?

> I'm not sure I understand your idea.

Second idea (TST_ALL_FILESYSTEMS=1 => .all_filesystems=1) is wrong.

I was thinking how to run fsplough in nfs10.sh similarly to
testcases/lib/tests/shell_loader_c_child.sh to use $LTP_IPC_PATH.  That would
help better integration (e.g. common results counter, maybe even timeout on
single place). This should be quite easy.

I was also thinking whether rewrite nfs_lib.sh into C (much more work,
there would probably  need to be tst_net.sh equivalent in C questionable if
worth of the effort).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-11-12 21:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 14:11 [LTP] [PATCH 0/5] Add LVM and NFS tests for file data integrity Martin Doucha
2024-11-01 14:11 ` [LTP] [PATCH 1/5] Move preadv()/pwritev() backup definitions to LAPI Martin Doucha
2024-11-01 22:40   ` Petr Vorel
2024-11-01 14:11 ` [LTP] [PATCH 2/5] Add safe readv()/writev() functions Martin Doucha
2024-11-01 14:11 ` [LTP] [PATCH 3/5] Add test for file data integrity Martin Doucha
2024-12-04 13:45   ` Cyril Hrubis
2024-12-04 14:39     ` Martin Doucha
2024-11-01 14:11 ` [LTP] [PATCH 4/5] Add support for setting loop device size in shell tests Martin Doucha
2024-11-01 22:45   ` Petr Vorel
2024-11-28  8:19     ` Petr Vorel
2024-11-01 14:11 ` [LTP] [PATCH 5/5] Add test for data integrity over NFS Martin Doucha
2024-11-01 23:32   ` Petr Vorel
2024-11-04 13:05     ` Cyril Hrubis
2024-11-04 13:19       ` Cyril Hrubis
2024-11-04 13:32         ` Cyril Hrubis
2024-11-04 15:59           ` Petr Vorel
2024-11-12 21:23             ` Petr Vorel
2024-11-13 13:44               ` Cyril Hrubis
2024-11-04 14:16       ` Petr Vorel
2024-11-12 12:50     ` Martin Doucha
2024-11-12 21:40       ` Petr Vorel [this message]
2024-11-13 14:02         ` Martin Doucha
2024-11-13 14:50           ` Petr Vorel
2024-11-13 13:48       ` Cyril Hrubis
2024-11-28  8:27     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112214015.GA235246@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox