Re: [LTP] [PATCH v2] kcmp: Convert docs to docparse

Petr Vorel
2024-11-12T23:07:15Z

Hi Ma Xinjian,

...
> diff --git a/testcases/kernel/syscalls/kcmp/kcmp02.c b/testcases/kernel/syscalls/kcmp/kcmp02.c
> +/*\
> + * [Description]
> + *
> + * Verify that, kcmp() returns -1 and sets errno to
> + *
> + * 1. ESRCH if pid does not exist
> + * 2. EINVAL if type is invalid (it's not in man page)
> + * 3. EINVAL if type is invalid (it's a negative number, -1)
> + * 4. EINVAL if type is invalid (it's a negative number, the smallest integer)
> + * 5. EINVAL if type is invalid (it's too high, the largest integer)
> + * 6. EBADF if fd is invalid
I slightly changed this and merged.

IMHO it's better to use "file descriptor" then just fd (although it's obvious,
let's be more formal). OTOH we can use commonly used constants (INT_MAX, ...)
instead of "the largest integer").

Thanks!

Kind regards,
Petr

--
Mailing list info: https://lists.linux.it/listinfo/ltp