From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls
Date: Thu, 14 Nov 2024 00:11:56 +0100 [thread overview]
Message-ID: <20241113231156.GA306618@pevik> (raw)
In-Reply-To: <ZzMRKZdtyIbsy0cN@wegao>
Hi all,
...
> > +#ifdef HAVE_LINUX_LSM_H
> > +#include <linux/lsm.h>
> > +#endif
> I guess s/#endif/#else ?
IMHO this is correct. This guards just <linux/lsm.h> (added in 6.7).
All other fallback definitions are guarded by other checks, because UAPI headers
evolve over time, thus it would not help to guard all fallback definitions just
by HAVE_LINUX_LSM_H. Check other lapi headers, vast majority of those who
include header add fallback definitions will do it this way.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-11-13 23:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 7:15 [LTP] [PATCH 0/7] LSM testing suite Andrea Cervesato
2024-11-12 7:15 ` [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls Andrea Cervesato
2024-11-12 8:26 ` Wei Gao via ltp
2024-11-13 23:11 ` Petr Vorel [this message]
2024-11-14 1:55 ` Wei Gao via ltp
2024-12-18 18:24 ` Petr Vorel
2024-11-12 7:15 ` [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test Andrea Cervesato
2024-12-18 18:55 ` Petr Vorel
2025-01-07 8:50 ` Andrea Cervesato via ltp
2025-01-08 8:53 ` Andrea Cervesato via ltp
2025-01-08 12:52 ` Cyril Hrubis
2024-11-12 7:15 ` [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test Andrea Cervesato
2025-01-08 12:58 ` Cyril Hrubis
2025-01-08 13:13 ` Andrea Cervesato via ltp
2025-01-08 13:35 ` Cyril Hrubis
2024-11-12 7:15 ` [LTP] [PATCH 4/7] Add lsm_get_self_attr03 test Andrea Cervesato
2024-11-12 7:15 ` [LTP] [PATCH 5/7] Add lsm_list_modules01 test Andrea Cervesato
2025-01-08 13:49 ` Cyril Hrubis
2024-11-12 7:15 ` [LTP] [PATCH 6/7] Add lsm_list_modules02 test Andrea Cervesato
2025-01-08 14:05 ` Cyril Hrubis
2024-11-12 7:15 ` [LTP] [PATCH 7/7] Add lsm_set_self_attr01 test Andrea Cervesato
2024-12-18 19:03 ` Petr Vorel
2025-01-08 8:50 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113231156.GA306618@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox