From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/5] mq_timedsend01: Workaround segfault on libc variant on 32 bit
Date: Mon, 25 Nov 2024 10:28:14 +0100 [thread overview]
Message-ID: <20241125092814.GA298526@pevik> (raw)
In-Reply-To: <CAASaF6xC-PJC79cSbH_NVGYcTTkApYuOkyXDL8p8GQa0k=-vgw@mail.gmail.com>
Hi Jan,
...
> > > > + if (tc->bad_ts_addr) {
> > > Would it make sense to run bad_msg_addr/EFAULT test also in child?
> > First, thanks a lot a review.
> > I'm not sure myself. So far it's not needed (problem is only with struct
> > timespec *abs_timeout not with const char msg_ptr[]). But OTOH it does not
> > harm. Doing this might prevent some failure in the future.
> It was only as a precaution. Either way, feel free to add to series:
> Acked-by: Jan Stancek <jstancek@redhat.com>
Thanks a lot for your review. Merged with changing bad_msg_addr/EFAULT being
tested also in child.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-11-25 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 14:40 [LTP] [PATCH 0/5] mq_timedsend01: sigtimedwait01: Workaround segfault on libc variant on 32 bit Petr Vorel
2024-11-14 14:40 ` [LTP] [PATCH 1/5] mq_timedsend01: Fix different signedness error on 32bit Petr Vorel
2024-11-14 14:40 ` [LTP] [PATCH 2/5] mq_timedsend01: Remove unneeded designated initializers Petr Vorel
2024-11-14 14:40 ` [LTP] [PATCH 3/5] mq_timedsend01: Workaround segfault on libc variant on 32 bit Petr Vorel
2024-11-15 13:13 ` Jan Stancek
2024-11-15 14:00 ` Petr Vorel
2024-11-18 9:45 ` Jan Stancek
2024-11-25 9:28 ` Petr Vorel [this message]
2024-11-14 14:40 ` [LTP] [PATCH 4/5] libs/sigwait: " Petr Vorel
2024-11-14 14:40 ` [LTP] [PATCH 5/5] libs/sigwait: Use safe/test macros Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125092814.GA298526@pevik \
--to=pvorel@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox