From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] recvmmsg01: Workaround segfault on libc variant on 32 bit
Date: Mon, 25 Nov 2024 22:32:41 +0100 [thread overview]
Message-ID: <20241125213241.GA15008@pevik> (raw)
In-Reply-To: <ZzHehDjWzY7ZMXyC@yuki.lan>
...
> > +static void test_bad_addr(unsigned int i)
> > +{
> > + struct time64_variants *tv = &variants[tst_variant];
> > + void *timeout = bad_addr;
> > + pid_t pid;
> > + int status;
> > +
> > + pid = SAFE_FORK();
> > + if (!pid) {
> > + verify_recvmmsg(i, timeout);
> > + _exit(!TST_PASS);
> This should be just exit(0). The child should either crash or exit with
> 0 any other result should be considered a bug.
Hm, I changed before merge it to _exit(0), instead of exit(0). As Jan explained
[1] _exit() is just for signal handlers and exit() will also flush open streams.
I guess I should fix it.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/CAASaF6yDG9VfWOzaSbzEMSGq5LXrqkNfLF7UmMcdWNvqmYywtA@mail.gmail.com/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-11-25 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 12:21 [LTP] [PATCH 1/1] recvmmsg01: Workaround segfault on libc variant on 32 bit Petr Vorel
2024-11-11 8:30 ` Wei Gao via ltp
2024-11-11 9:58 ` Petr Vorel
2024-11-11 10:37 ` Cyril Hrubis
2024-11-11 14:24 ` Petr Vorel
2024-11-25 21:32 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125213241.GA15008@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox