From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 5/5] setsockopt0[38]: Use tst_is_compat_mode()
Date: Tue, 26 Nov 2024 18:47:50 +0100 [thread overview]
Message-ID: <20241126174750.GA100857@pevik> (raw)
In-Reply-To: <Z0Xi6wJvluwhCxNC@yuki.lan>
Hi Cyril,
> Hi!
> > > I guess this is something that should be looked into after the release,
> > > either we will need .needs_compat flag or relax the condtions...
> > Looking into this old patch, do we relax the conditions or use .needs_abi_bits = 32?
> > setsockopt08.c prints only TINFO, thus !tst_is_compat_mode() would have to be
> > used for the check.
> I guess that doing:
> if (!tst_is_compat_mode())
> tst_res(TINFO, "The vunerability was only present in 32-bit compat mode");
> Is a sensible approach. It does not hurt to run the test either way but
> it makes it clear that the original CVE it's not going to be reproduced
> without 32-bit compat mode.
+1. I modified that and dared to merge with your RBT (9dacb1ac27).
Thanks for your review!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-11-26 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 10:53 [LTP] [PATCH v2 0/5] .needs_abi_bits + rewrite fork14 to new API Petr Vorel
2024-05-21 10:53 ` [LTP] [PATCH v2 1/5] tst_kernel.h: Convert docs to sphinx Petr Vorel
2024-05-21 12:06 ` Andrea Cervesato via ltp
2024-05-21 10:53 ` [LTP] [PATCH v2 2/5] lib: Add .needs_abi_bits Petr Vorel
2024-05-21 15:11 ` Cyril Hrubis
2024-05-21 10:53 ` [LTP] [PATCH v2 3/5] Refactor fork14 using new LTP API Petr Vorel
2024-05-21 12:03 ` Andrea Cervesato via ltp
2024-05-21 10:53 ` [LTP] [PATCH v2 4/5] sbrk03: Convert to detect support with flags Petr Vorel
2024-05-21 15:12 ` Cyril Hrubis
2024-05-21 10:53 ` [LTP] [PATCH v2 5/5] setsockopt0[38]: Use tst_is_compat_mode() Petr Vorel
2024-05-21 15:12 ` Cyril Hrubis
2024-05-21 18:34 ` Petr Vorel
2024-11-26 14:35 ` Petr Vorel
2024-11-26 15:02 ` Cyril Hrubis
2024-11-26 17:47 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126174750.GA100857@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox