Re: [LTP] [PATCH v2] Add test for data integrity over NFS

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

...
> +TST_CNT=4
> +TST_TESTFUNC="do_test"
> +TST_DEVICE_SIZE=1024
> +TST_TIMEOUT=2400

It looks like block size (f_bsize member of struct statvfs) differs depending on
RAM. Testing on s390x VM:

* 1 GB => block size: 131072
* 2 GB => block size: 262144
* 4 GB => block size: 524288

This can cause timeouts depending on the machine setup.
How about changing TST_TIMEOUT=-1 ? I don't like unlimited setup, but in this
case I would keep it. Timeout is handled by fsplough.c anyway.
If you agree, I can change during merge.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +
> +do_test1()
> +{
> +	tst_res TINFO "Testing buffered write, buffered read"
> +	EXPECT_PASS fsplough -c 512 -d "$PWD"
> +}
> +
> +do_test2()
> +{
> +	tst_res TINFO "Testing buffered write, direct read"
> +	EXPECT_PASS fsplough -c 512 -R -d "$PWD"
> +}
> +
> +do_test3()
> +{
> +	tst_res TINFO "Testing direct write, buffered read"
> +	EXPECT_PASS fsplough -c 512 -W -d "$PWD"
> +}
> +
> +do_test4()
> +{
> +	tst_res TINFO "Testing direct write, direct read"
> +	EXPECT_PASS fsplough -c 512 -RW -d "$PWD"
> +}
> +
> +. nfs_lib.sh
> +tst_run

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp