Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero

Cyril Hrubis
2024-12-11T12:09:05Z

Hi!
> Well, "Testing only" in the help (-h) was added there to suggest it's for
> testing/debugging LTP, not a production testing. But newer mind, I'll implement
> Cyril's suggestion, real usage justify it. + I'll add LTP_FORCE_SINGLE_FS_TYPE.
>
> We could allow more filesystems, e.g. instead of running LTP few times with
> different LTP_SINGLE_FS_TYPE value: e.g.
>
> for fs in ext4 xfs btrfs; do LTP_SINGLE_FS_TYPE=fs ioctl_ficlone02; done
>
> we could introduce support for particular filesystems
> LTP_FILESYSTEMS="ext4,xfs,btrfs" ioctl_ficlone02

That is stil not equivalent if you run it with a whole LTP. We would
have to run each test that uses device for all LTP_FILESYSTEMS, since
many of the testcases does use device but does not use .all_filesystems.

So all in all I think that LTP_SINGLE_FS_TYPE is good enough solution.

Or we can try to rething the whole thing, but it's getting quite
complicated with all the options we have.

--
Cyril Hrubis
chrubis@suse.cz