Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero

Cyril Hrubis
2024-12-02T13:36:39Z

Hi!
> This test need to skip test known filesystems, but according to below
> code logic (in lib/tst_test.c):
>
> if (!tst_test->all_filesystems && tst_test->skip_filesystems) {
> long fs_type = tst_fs_type(".");
> const char *fs_name = tst_fs_type_name(fs_type);
>
> if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
> tst_brk(TCONF, "%s is not supported by the test",
> fs_name);
> }
>
> tst_res(TINFO, "%s is supported by the test", fs_name);
> }
>
> if all_filesystems is 1, the skip_filesystems doesn't work. So set
> all_filesystems to 0.

The code to skip filesystems in the case of all filesystems is in the
run_tcase_per_fs() function:

static int run_tcases_per_fs(void)
{
int ret = 0;
unsigned int i;
const char *const *filesystems = tst_get_supported_fs_types(tst_test->skip_filesystems);

The skip_filesystems array is passed to the tst_get_supporte_fs_types()
function which filters out them.

--
Cyril Hrubis
chrubis@suse.cz