Re: [LTP] [PATCH] controllers/cpuset: Add backslash to dump full fail log

Zhao Mengmeng
2025-05-07T15:14:58Z

On 2025/4/29 15:55, Andrea Cervesato wrote:
> Hi!
>
> I'm gonna merge this, removing backlash and joining the strings.
>
> Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
>
> On 12/17/24 22:48, Petr Vorel wrote:
>> Hi Zhao Mengmeng,
>>
>>> While debugging LTP cpuset_load_balance_test, when rmdir a path failed,
>>> it only dumps part of the log, missing the $subdir. Add backslash to fix
>>> it.
>> +1 good catch.
>>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>>> Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
>>> ---
>>>   testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> index 567178e3fd52..a374fd71f790 100755
>>> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> @@ -195,7 +195,7 @@ cleanup()
>>>           done < "$subdir/tasks"
>>>           rmdir "$subdir"
>>>           if [ $? -ne 0 ]; then
>>> -            tst_brkm TFAIL "Couldn't remove subdir - "
>>> +            tst_brkm TFAIL "Couldn't remove subdir - "\
>>>                           "$subdir in the cpuset"
>> Could we please just join the string?
>>             tst_brkm TFAIL "Couldn't remove subdir - $subdir in the cpuset"
>>
>> Kind regards,
>> Petr
>>
>>>           fi
>>>       done

Thanks, Andrea. Actually I have already sent a v2 patch removing backlash and joining the strings
to LTP at 2024/12/18, but got no reply on it.