From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib: multiply the timeout if detect slow kconfigsD
Date: Tue, 7 Jan 2025 17:49:43 +0100 [thread overview]
Message-ID: <20250107164943.GA396751@pevik> (raw)
In-Reply-To: <Z30hKu11NUNI_uaJ@yuki.lan>
> Hi!
> > Ah, you mean we multiply the overall test time limit results->timeout,
> > right?
> > e.g.
> > results->timeout = (default_30s_timeout + tst_test->timeout) *
> > TIMEOUT_MUL + tst_test->runtime * RUNTIME_MUL;
> > if (tst_has_slow_kconfig())
> > results->timeout *= 4;
> That would work too, but since the runtime will be always constant (once
> only the test that call tst_remaning_runtime() use runtime and the rest
> of the tests is moved to timeout) we may as well multiply the timeout
> part.
> However this detail does not matter that much, the most imporatant part
> is the clear separation of the guessed upper bound and the actual
> runtime that is used to controll how long should the loop in the test
> spin.
Thanks this for explanation.
BTW do you plan to send a patch soon? If not I would prefer to temporarily
revert 2da30df24e (or just *= 4), which causes some tests to timeout.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-07 16:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 7:22 [LTP] [PATCH 1/2] lib: multiply the timeout if detect slow kconfigs Li Wang
2024-12-22 7:22 ` [LTP] [PATCH 2/2] starvation: skip test on slow kernel Li Wang
2025-01-02 12:56 ` Petr Vorel
2025-01-02 14:31 ` Petr Vorel
2025-01-03 7:53 ` Li Wang
2025-01-02 12:43 ` [LTP] [PATCH 1/2] lib: multiply the timeout if detect slow kconfigs Petr Vorel
2025-01-03 5:00 ` Li Wang
2025-01-03 7:06 ` Petr Vorel
2025-01-03 7:33 ` Petr Vorel
2025-01-03 7:58 ` Li Wang
2025-01-03 15:48 ` [LTP] [PATCH 1/2] lib: multiply the timeout if detect slow kconfigsD Cyril Hrubis
2025-01-04 3:38 ` Li Wang
2025-01-06 9:35 ` Petr Vorel
2025-01-06 12:10 ` Cyril Hrubis
2025-01-06 12:52 ` Petr Vorel
2025-01-06 13:39 ` Cyril Hrubis
2025-01-06 15:36 ` Petr Vorel
2025-01-06 16:19 ` Cyril Hrubis
2025-01-07 5:37 ` Li Wang
2025-01-07 6:28 ` Li Wang
2025-01-07 12:42 ` Cyril Hrubis
2025-01-07 16:49 ` Petr Vorel [this message]
2025-01-08 1:47 ` Li Wang
2025-01-08 2:51 ` Li Wang
2025-01-06 16:03 ` Martin Doucha
2025-01-06 16:21 ` Cyril Hrubis
2025-01-06 16:49 ` Martin Doucha
2025-01-15 22:41 ` [LTP] [REGRESSION] Broken tests using tst_net.sh by 893ca0abe7 (was: [PATCH 1/2] lib: multiply the timeout if detect slow kconfigs) Petr Vorel
2025-01-16 6:54 ` Li Wang
2025-01-16 8:35 ` Petr Vorel
2025-01-16 8:38 ` Petr Vorel
2025-01-16 12:10 ` Li Wang
2025-01-16 12:13 ` Li Wang
2025-01-16 13:13 ` Petr Vorel
2025-01-16 12:56 ` Petr Vorel
2025-01-20 9:07 ` [LTP] [REGRESSION] pidns05 timeout " Petr Vorel
2025-01-20 9:11 ` Petr Vorel
2025-01-20 10:18 ` Li Wang
2025-01-20 12:29 ` Cyril Hrubis
2025-01-20 13:03 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107164943.GA396751@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox