From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/6] tst_run_shell: Make the tst_test struct static
Date: Wed, 8 Jan 2025 14:12:12 +0100 [thread overview]
Message-ID: <20250108131212.GA30426@pevik> (raw)
In-Reply-To: <20250106132607.25627-3-chrubis@suse.cz>
Hi Cyril,
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/lib/tst_run_shell.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/lib/tst_run_shell.c b/testcases/lib/tst_run_shell.c
> index 0b86233dd..54463c04d 100644
> --- a/testcases/lib/tst_run_shell.c
> +++ b/testcases/lib/tst_run_shell.c
> @@ -26,7 +26,7 @@ static void run_shell_tcnt(unsigned int n)
> tst_run_script(shell_filename, params);
> }
> -struct tst_test test = {
> +static struct tst_test test = {
Thanks!
Could you please before merge also fix formatting error?
tst_run_shell.c:144: ERROR: "(foo*)" should be "(foo *)"
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> .runs_script = 1,
> };
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-08 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 13:26 [LTP] [PATCH v2 0/6] First new shell library converted test Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 1/6] tst_run_shell: Add save_restore parser Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 2/6] tst_run_shell: Make the tst_test struct static Cyril Hrubis
2025-01-08 13:12 ` Petr Vorel [this message]
2025-01-14 12:48 ` Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 3/6] libs/ujson: Fix "Garbage after JSON string!" in strict mode Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 4/6] tst_run_shell: Better errors for metadata extractor Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 5/6] lib/tst_res_.c: Add TBROK handler + more verbose errors Cyril Hrubis
2025-01-06 13:26 ` [LTP] [PATCH v2 6/6] mem/vma05.sh: Convert to the new shell library Cyril Hrubis
2025-01-06 15:15 ` Petr Vorel
2025-01-06 16:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108131212.GA30426@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox