From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] testinfo.pl: Properly handle NULL
Date: Thu, 9 Jan 2025 15:31:14 +0100 [thread overview]
Message-ID: <20250109143114.GA327086@pevik> (raw)
In-Reply-To: <20250109142847.326936-1-pvorel@suse.cz>
Hi Cyril,
> While at it, add missing comma to the arguments.
I forget to note perl error:
$ cd metadata; make
metadata/parse.sh > ltp.json
mkdir -p docparse
make -C docparse/ -f docparse/Makefile
make[1]: Entering directory 'docparse'
docparse/testinfo.pl metadata/ltp.json
INFO: using 'linux' as LINUX_GIT repository
INFO: using 'linux-stable' as LINUX_STABLE_GIT repository
INFO: using 'glibc' as GLIBC_GIT repository
INFO: using 'musl' as MUSL_GIT repository
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Use of uninitialized value in join or string at docparse/testinfo.pl line 411.
Kind regards,
Petr
> Fixes: 946d20bdaf ("metadata: metaparse: Better array parsing.")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> NOTE: if we don't want to have NULL in the docs (see e.g. hugemmap10),
> we can simply filer it:
> $content .= paragraph(table_escape(join(', ', grep defined, @$v2)));
> docparse/testinfo.pl | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> diff --git a/docparse/testinfo.pl b/docparse/testinfo.pl
> index 78433c40a3..487b7d5f22 100755
> --- a/docparse/testinfo.pl
> +++ b/docparse/testinfo.pl
> @@ -408,7 +408,11 @@ sub content_all_tests
> # two dimensional array
> if (ref(@$v[0]) eq 'ARRAY') {
> for my $v2 (@$v) {
> - $content .= paragraph(table_escape(join(' ', @$v2)));
> + # convert NULL to "NULL" string to be printed
> + for my $v3 (@$v2) {
> + $v3 = "NULL" if (!defined $v3);
> + }
> + $content .= paragraph(table_escape(join(', ', @$v2)));
> }
> } else {
> # one dimensional array
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-09 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 14:28 [LTP] [PATCH 1/1] testinfo.pl: Properly handle NULL Petr Vorel
2025-01-09 14:31 ` Petr Vorel [this message]
2025-01-09 15:09 ` Cyril Hrubis
2025-01-09 16:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109143114.GA327086@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox