public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] macros: Add basic docs
Date: Fri, 10 Jan 2025 15:57:26 +0100	[thread overview]
Message-ID: <20250110145726.GA413134@pevik> (raw)
In-Reply-To: <a8437881-a652-4847-9907-41922126bece@suse.com>

Hi Andrea,

> Hi Petr,

> thanks for this documentation. It's really needed.

Yes, I had it long time in my mind. Thanks for the review.
...
> > +++ b/include/tst_test_macros.h
> > @@ -1,7 +1,11 @@
> >   // SPDX-License-Identifier: GPL-2.0-or-later
> >   /*
> >    * Copyright (c) 2015-2024 Cyril Hrubis <chrubis@suse.cz>
> > - * Copyright (c) Linux Test Project, 2021-2022
> > + * Copyright (c) Linux Test Project, 2021-2024
> > + */
> > +
> > +/**
> > + * DOC: tst_test_macros.h -- helpers for testing syscalls
> >    */
> Is this really needed?

Well, IMHO throwing just functions description to users is not enough.
I would even add a short description about the goal of these macros.

And because sooner or later as we increase sphinx doc in the headers the list
will be quite long. Therefore for the start I added just a title (short
paragraph with a description would be of curse  better).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-01-10 14:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 13:23 [LTP] [PATCH 1/2] [RFC] macros: Remove TEST_VOID() Petr Vorel
2025-01-09 13:23 ` [LTP] [PATCH 2/2] macros: Add basic docs Petr Vorel
2025-01-09 13:35   ` Andrea Cervesato via ltp
2025-01-10 14:57     ` Petr Vorel [this message]
2025-01-14 14:44       ` Andrea Cervesato via ltp
2025-05-09  7:00       ` Li Wang via ltp
2025-05-12  9:17   ` Avinesh Kumar
2025-06-09  7:17     ` Petr Vorel
2025-01-14 14:46 ` [LTP] [PATCH 1/2] [RFC] macros: Remove TEST_VOID() Andrea Cervesato via ltp
2025-01-14 16:20   ` Petr Vorel
2025-05-09  6:46 ` Li Wang via ltp
2025-06-09  7:14   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250110145726.GA413134@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox