public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: add TST_NO_SLOW_KCONFIG_CHECK macro for testcase tools
Date: Fri, 17 Jan 2025 09:15:18 +0100	[thread overview]
Message-ID: <20250117081518.GA733756@pevik> (raw)
In-Reply-To: <CAEemH2e4VnKVHUEKPKsa0LUkx1gGdii_tZxtiqA9TBfd6SBRNA@mail.gmail.com>

> On Fri, Jan 17, 2025 at 4:05 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Li,

> > > Hi Li,

> > > > The macro TST_NO_SLOW_KCONFIG_CHECK is added to control whether
> > > > the tst_has_slow_kconfig() function (which presumably checks for
> > > > slow kernel configurations) should be executed.

> > > That was quick, thanks a lot!

> > > But unfortunately the patch does not help to avoid printing TINFO
> > > (tested on a fresh clone):

> > > # make && ./tst_ns_exec 14536 net,mnt sh -c " cat
> > /proc/sys/net/ipv6/conf/ltp_ns_veth1/disable_ipv6"
> > > CC testcases/lib/tst_ns_exec
> > > make[1]: Nothing to be done for 'all'.
> > > tst_kconfig.c:88: TINFO: Parsing kernel config '/proc/config.gz'
> > > tst_kconfig.c:667: TINFO: CONFIG_LATENCYTOP kernel option detected which
> > might slow the execution
> > > 0

> > > Maybe it's because safe_clone() triggers it? Or what am I missing?

> > The problem why it does not work is that it uses lib/tst_test.o via
> > lib/libltp.a, which was compiled without TST_NO_SLOW_KCONFIG_CHECK.


> Really? How does that TST_NO_DEFAULT_MAIN work?
> Reading the code...

I guess the code which evaluates TST_NO_DEFAULT_MAIN must be in static inline
function in tst_test.h header. Then it will work.

Kind regards,
Petr

> > IMHO We cannot easily solve this with preprocessor definition.

> > Kind regards,
> > Petr

> > > Kind regards,
> > > Petr

> > > > This allows test cases and tools to opt out of this additional
> > > > check, enabling more flexible and faster test execution in
> > > > certain scenarios.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-01-17  8:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  7:17 [LTP] [PATCH] lib: add TST_NO_SLOW_KCONFIG_CHECK macro for testcase tools Li Wang
2025-01-17  7:36 ` Petr Vorel
2025-01-17  8:04   ` Petr Vorel
2025-01-17  8:13     ` Li Wang
2025-01-17  8:15       ` Petr Vorel [this message]
2025-01-17  8:20         ` Li Wang
2025-01-17  7:48 ` Andrea Cervesato via ltp
2025-01-17  8:27   ` Li Wang
2025-01-17  8:43     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117081518.GA733756@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox