From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: add TST_NO_SLOW_KCONFIG_CHECK macro for testcase tools
Date: Fri, 17 Jan 2025 09:43:52 +0100 [thread overview]
Message-ID: <20250117084352.GB733756@pevik> (raw)
In-Reply-To: <CAEemH2f4DoH4Lggpncbh9OmCcu0AQBc8Fp_yczE5EG2C=MLn+w@mail.gmail.com>
Hi all,
> On Fri, Jan 17, 2025 at 3:49 PM Andrea Cervesato <andrea.cervesato@suse.com>
> wrote:
> > Hi Li,
> > the feature is interesting, but I have the feeling this should be added
> > to tst_test struct rather than using a flag at compile time.
> > For example, by adding to tst_test a slow_kconfig attribute.
> Thanks. But sounds a little bit unnecessary to add new field in tst_test
> struct.
> What about using an global variable like tst_no_slow_kcofig_check ?
This could work.
I sent a patch which takes yet another option: static inline function which
differs based on existing TST_NO_DEFAULT_MAIN. That keeps the functionality for
tests only, avoid it for libraries.
Actually similar approach Li did, but moved to header (it cannot be in C file).
Kind regards,
Petr
> > Andrea
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-01-17 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 7:17 [LTP] [PATCH] lib: add TST_NO_SLOW_KCONFIG_CHECK macro for testcase tools Li Wang
2025-01-17 7:36 ` Petr Vorel
2025-01-17 8:04 ` Petr Vorel
2025-01-17 8:13 ` Li Wang
2025-01-17 8:15 ` Petr Vorel
2025-01-17 8:20 ` Li Wang
2025-01-17 7:48 ` Andrea Cervesato via ltp
2025-01-17 8:27 ` Li Wang
2025-01-17 8:43 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117084352.GB733756@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox