Re: [LTP] [PATCH v7 2/2] ptrace06: Refactor the test using new LTP API

[Petr Vorel <pvorel@suse.cz>]

Hi Wei,

...
> --- /dev/null
> +++ b/testcases/kernel/syscalls/ptrace/ptrace06_child.c
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2018 Linux Test Project
> + * Copyright (C) 2015 Cyril Hrubis chrubis@suse.cz
> + */
> +
> +#define TST_NO_DEFAULT_MAIN
> +#include "tst_test.h"
> +
> +int main(int argc, char *argv[])

ptrace06_child.c:10:14: warning: unused parameter ‘argc’ [-Wunused-parameter]
   10 | int main(int argc, char *argv[])

> +{
> +
nit: empty line ^
> +	tst_res(TPASS, "%s executed", argv[0]);
> +
> +	return 0;
> +}

I suggest to merge the patchset with this change in this commit.

@Cyril: Can I add your RBT?

Kind regards,
Petr

+++ testcases/kernel/syscalls/ptrace/ptrace06_child.c
@@ -7,9 +7,8 @@
 #define TST_NO_DEFAULT_MAIN
 #include "tst_test.h"
 
-int main(int argc, char *argv[])
+int main(int argc LTP_ATTRIBUTE_UNUSED, char *argv[])
 {
-
 	tst_res(TPASS, "%s executed", argv[0]);
 
 	return 0;

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp