public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/5] LTP fanotify tests for v6.13
Date: Wed, 22 Jan 2025 21:50:23 +0100	[thread overview]
Message-ID: <20250122205023.GA48906@pevik> (raw)
In-Reply-To: <20250122172440.506677-1-amir73il@gmail.com>

Hi Amir,

> Hi all,

> Following tests for fanotify code in v6.13.

> 1. The new test case in fanotify13 fails as follows on kernels v6.6..v6.12:

> fanotify13.c:282: TFAIL: handle_bytes (0) returned in event does not equal to handle_bytes (24) returned in name_to_handle_at(2)
> fanotify13.c:282: TFAIL: handle_bytes (0) returned in event does not equal to handle_bytes (24) returned in name_to_handle_at(2)
> fanotify13.c:282: TFAIL: handle_bytes (180003) returned in event does not equal to handle_bytes (24) returned in name_to_handle_at(2)

> The fix was already backported to v6.12.10.
> It was also backported to v6.6.72,
> but then reverted due to a backport bug in v6.6.73
> and it now staged again for v6.6.74.


> 2. The new variant of fanotify21 is skipped on kernels <= v6.12

> This variant tests the new feature flag FAN_REPORT_FD_ERROR, which is
> not effectively a bug fix.

> Because this feature was added as a consequence of a bug report,
> it was auto backported to v6.12.5 and to v6.6.66, but I do not
> feel comfortable with adding a fix tag to force distros to backport
> this feature.

We have git freeze before new release. But IMHO this should go in.
It works well on v6.13, I'll retest it on SLES kernels.

Kind regards,
Petr

> Thanks,
> Amir.

> Amir Goldstein (5):
>   fanotify13: Verify that we did not get an extra event
>   fanotify13: Add test case for FAN_DELETE_SELF
>   fanotify05: Test reporting overflow event with FAN_REPORT_FD_ERROR
>   fanotify21: Test reporting event with RDWR fd on RO mount
>   fanotify21: Test reporting fd open errors with FAN_REPORT_FD_ERROR

>  include/lapi/fanotify.h                       |  4 +
>  testcases/kernel/syscalls/fanotify/fanotify.h |  1 +
>  .../kernel/syscalls/fanotify/fanotify05.c     | 18 +++-
>  .../kernel/syscalls/fanotify/fanotify13.c     | 90 ++++++++++++++++---
>  .../kernel/syscalls/fanotify/fanotify21.c     | 89 ++++++++++++++++--
>  5 files changed, 177 insertions(+), 25 deletions(-)

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2025-01-22 20:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 17:24 [LTP] [PATCH 0/5] LTP fanotify tests for v6.13 Amir Goldstein
2025-01-22 17:24 ` [LTP] [PATCH 1/5] fanotify13: Verify that we did not get an extra event Amir Goldstein
2025-01-23 17:18   ` Petr Vorel
2025-01-24 10:11     ` Petr Vorel
2025-01-24 10:33       ` Amir Goldstein
2025-01-24 12:45         ` Petr Vorel
2025-01-22 17:24 ` [LTP] [PATCH 2/5] fanotify13: Add test case for FAN_DELETE_SELF Amir Goldstein
2025-01-22 17:24 ` [LTP] [PATCH 3/5] fanotify05: Test reporting overflow event with FAN_REPORT_FD_ERROR Amir Goldstein
2025-01-24  7:44   ` Petr Vorel
2025-01-22 17:24 ` [LTP] [PATCH 4/5] fanotify21: Test reporting event with RDWR fd on RO mount Amir Goldstein
2025-01-24  8:01   ` Petr Vorel
2025-01-22 17:24 ` [LTP] [PATCH 5/5] fanotify21: Test reporting fd open errors with FAN_REPORT_FD_ERROR Amir Goldstein
2025-01-24  8:09   ` Petr Vorel
2025-01-22 20:50 ` Petr Vorel [this message]
2025-01-23 13:09   ` [LTP] [PATCH 0/5] LTP fanotify tests for v6.13 Amir Goldstein
2025-01-23 13:31     ` Cyril Hrubis
2025-01-24 10:46   ` Cyril Hrubis
2025-01-24 11:32     ` Petr Vorel
2025-01-30 20:07     ` Petr Vorel
2025-01-31 14:16       ` Amir Goldstein
2025-01-31 16:42         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122205023.GA48906@pevik \
    --to=pvorel@suse.cz \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox