From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F752C0218C for ; Thu, 23 Jan 2025 20:50:32 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CC3853C4F54 for ; Thu, 23 Jan 2025 21:50:30 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1C2313C2A69 for ; Thu, 23 Jan 2025 21:50:12 +0100 (CET) Authentication-Results: in-6.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 66C491425080 for ; Thu, 23 Jan 2025 21:50:11 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2AB681F391; Thu, 23 Jan 2025 20:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737665411; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=unSDzxtBFHtcf7EOP+ONNltcsDmJI3M7qa7fhLV5Qx8=; b=IsvSlsN5RzrYMrDSnbVJINXx++BjGSrTcMQ5d6kj3EtyWgyrbTqB7SOZ7gAYNdl8r3CDmN aQE/BMuH7WHG9wLATrFB6uT9AY8TSplDJOLDb2NbVwRhcVfEMI7+G6oxMAsGKJtQ21nm93 XGy5uU1FVrSQyoqP4jPAUxK+uOEP/Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737665411; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=unSDzxtBFHtcf7EOP+ONNltcsDmJI3M7qa7fhLV5Qx8=; b=lkPFXjUdSgH73CPxyCVbW36AYg0GIgTLqjTt2L8YUcpwGRvuxMW199hp3NAYhgjHS1EcNE NRqqIYEiIIbrstAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IsvSlsN5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lkPFXjUd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737665411; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=unSDzxtBFHtcf7EOP+ONNltcsDmJI3M7qa7fhLV5Qx8=; b=IsvSlsN5RzrYMrDSnbVJINXx++BjGSrTcMQ5d6kj3EtyWgyrbTqB7SOZ7gAYNdl8r3CDmN aQE/BMuH7WHG9wLATrFB6uT9AY8TSplDJOLDb2NbVwRhcVfEMI7+G6oxMAsGKJtQ21nm93 XGy5uU1FVrSQyoqP4jPAUxK+uOEP/Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737665411; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=unSDzxtBFHtcf7EOP+ONNltcsDmJI3M7qa7fhLV5Qx8=; b=lkPFXjUdSgH73CPxyCVbW36AYg0GIgTLqjTt2L8YUcpwGRvuxMW199hp3NAYhgjHS1EcNE NRqqIYEiIIbrstAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 51A3B136A1; Thu, 23 Jan 2025 20:50:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UgrIBoKrkmfqAgAAD6G6ig (envelope-from ); Thu, 23 Jan 2025 20:50:10 +0000 Date: Thu, 23 Jan 2025 21:50:04 +0100 From: Petr Vorel To: Li Wang Message-ID: <20250123205004.GA150153@pevik> References: <20250118102615.127485-1-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250118102615.127485-1-liwang@redhat.com> X-Rspamd-Queue-Id: 2AB681F391 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.3 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] lib: switch cgroup bit-fields from signed to unsigned int X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Li, > There is a problem in cgroup lib that the declearation int > can lead to -1 during the | operation. > Becasue if the field contains uninitialized garbage data, > a bit-field declared as int could interpret 0b1 as -1 due > to signed arithmetic. > By changing the type to unsigned int, the issue is avoided > since unsigned fields cannot represent negative values. Reviewed-by: Petr Vorel > Signed-off-by: Li Wang > Cc: Jin Guojie > --- > Notes: > @Cyril, Petr, I vote to merge this patch before the release. > @Guojie, Could you plz repost your memcontrol04 patch based on this change? +1 Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp