From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] flock: Add test for verifying EINTR errno
Date: Fri, 31 Jan 2025 12:01:36 +0100 [thread overview]
Message-ID: <20250131110136.GB1097590@pevik> (raw)
In-Reply-To: <6145632.lOV4Wx5bFT@thinkpad>
> On Monday, October 21, 2024 9:55:21 PM CET Petr Vorel wrote:
> > Hi Avinesh, Yang Xu,
> > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > Signed-off-by: Avinesh Kumar <akumar@suse.de>
> > ...
> > > --- /dev/null
> > > +++ b/testcases/kernel/syscalls/flock/flock07.c
> > > @@ -0,0 +1,70 @@
> > > +// SPDX-License-Identifier: GPL-2.0-or-later
> > > +/*
> > > + * Copyright (c) 2024 FUJITSU LIMITED. All Rights Reserved.
> > > + * Author: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > + * Copyright (c) 2024 Linux Test Project
> > > + */
> > > +
> > > +/*\
> > > + * [Description]
> > > + *
> > > + * Verify that flock(2) fails with errno EINTR when waiting to acquire a lock,
> > > + * and the call is interrupted by a signal.
> > Avinesh, you mentioned at Yang Xu's v1 [1] that EINTR test is getting timed out
> > randomly. I also experienced timeouts on aarch64 and ppc64le. v1 had 2 tests
> > (EINTR and EWOULDBLOCK), you here posted only EINTR. I would expect you would
> > put here only the other one - EWOULDBLOCK. Or am I missing something?
> Hi Petr,
> I am sorry, I completely missed this.
> I sent the patch for EWOULDBLOCK case now -
> https://lore.kernel.org/ltp/20250114155013.7644-1-akumar@suse.de/T/#u
Thanks for info. I'm closing this as rejected. Please let me know if I did not
understand you and this is a valid patch.
Kind regards,
Petr
> Regards,
> Avinesh
> > Kind regards,
> > Petr
> > [1] https://lore.kernel.org/ltp/1934768.7Z3S40VBb9@localhost/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-31 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:02 [LTP] [PATCH] flock: Add negative tests for flock Yang Xu via ltp
2024-05-30 14:13 ` Avinesh Kumar
2024-10-21 14:28 ` Petr Vorel
2024-05-30 14:40 ` [LTP] [PATCH v2] flock: Add test for verifying EINTR errno Avinesh Kumar
2024-05-30 14:48 ` [LTP] [PATCH v3] " Avinesh Kumar
2024-10-21 19:55 ` Petr Vorel
2025-01-14 15:54 ` Avinesh Kumar
2025-01-31 11:01 ` Petr Vorel [this message]
2025-02-03 9:41 ` Avinesh Kumar
2025-02-03 10:12 ` Petr Vorel
2025-02-03 14:22 ` Petr Vorel
2025-02-03 14:55 ` Avinesh Kumar
2025-02-03 15:33 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131110136.GB1097590@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox