Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] fsplough: Implement runtime awareness
Date: Tue, 11 Feb 2025 22:04:41 +0100	[thread overview]
Message-ID: <20250211210441.GA1933342@pevik> (raw)
In-Reply-To: <20250211122354.18324-1-mdoucha@suse.cz>

Hi Martin,

> Switch fsplough test to run for 30 seconds by default, with the option
> to set a fixed number of loops on command line instead. The test will
> always exit when runtime expires and a warning will be printed
> if there were too few iterations due to expired runtime.

+1
Reviewed-by: Petr Vorel <pvorel@suse.cz>

> +	if (i < loop_count / 2) {
> +		tst_res(TWARN, "Runtime expired, exiting early after %d loops",
> +			i);
> +		tst_res(TINFO, "If you are running on slow machine, "
> +			"try exporting LTP_TIMEOUT_MUL > 1");
> +	} else if (i < loop_count) {
> +		tst_res(TINFO, "Runtime expired, exiting early after %d loops",
> +			i);
> +	} else if (!loop_arg && i < 10) {
> +		tst_res(TWARN, "Slow sytem: test performed only %d loops!", i);
s/sytem/system/

I'll fix this before merge.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2025-02-11 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 12:23 [LTP] [PATCH 1/2] fsplough: Implement runtime awareness Martin Doucha
2025-02-11 12:23 ` [LTP] [PATCH 2/2] nfs10.sh: Remove fixed loop count from fsplough command Martin Doucha
2025-02-11 21:06   ` Petr Vorel
2025-02-11 21:44   ` Petr Vorel
2025-02-11 21:04 ` Petr Vorel [this message]
2025-02-12  9:41   ` [LTP] [PATCH 1/2] fsplough: Implement runtime awareness Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211210441.GA1933342@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox