Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Ma Xinjian <maxj.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] fork13: Fix the doc
Date: Wed, 19 Feb 2025 09:55:02 +0100	[thread overview]
Message-ID: <20250219085502.GA2544812@pevik> (raw)
In-Reply-To: <20250219052009.1020281-1-maxj.fnst@fujitsu.com>

Hi Ma Xinjian,

...
> +++ b/testcases/kernel/syscalls/fork/fork13.c
> @@ -15,21 +15,22 @@
>   * implementation.  Furthermore, many shell scripts assume that pid
>   * numbers will not be used for some length of time.
>   *
> - * [Race Description]
> - * ---------------------------------------------------------------------
> - * A                                B
> + * [Race Description] ::
>   *
> - * // pid == offset == n            // pid == offset == n + 1
> - * test_and_set_bit(offset, map->page)
> - *                                  test_and_set_bit(offset, map->page);
> - *                                  pid_ns->last_pid = pid;
> - * pid_ns->last_pid = pid;
> - *                                  // pid == n + 1 is freed (wait())
> + *    ---------------------------------------------------------------------
I removed these --- lines (they were for asciidoc code formatting).

> + *    A                                B
>   *
> - *                                  // Next fork()...
> - *                                  last = pid_ns->last_pid; // == n
> - *                                  pid = last + 1;
> - * ---------------------------------------------------------------------
> + *    // pid == offset == n            // pid == offset == n + 1
> + *    test_and_set_bit(offset, map->page)
And increase indent on the right side.

Thanks, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2025-02-19  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18  9:43 [LTP] [PATCH] fork13: Fix the doc Ma Xinjian via ltp
2025-02-18 12:17 ` Petr Vorel
2025-02-19  5:20   ` [LTP] [PATCH v2] " Ma Xinjian via ltp
2025-02-19  8:55     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250219085502.GA2544812@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=maxj.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox