Re: [LTP] [PATCH v1] mount_setattr02.c: Check mount_setattr attr.propagation

[Petr Vorel <pvorel@suse.cz>]

> On Wed, Feb 19, 2025 at 10:05:36AM +0100, Petr Vorel wrote:
> > > On Tue, Feb 18, 2025 at 04:18:58PM +0100, Petr Vorel wrote:
> > > > Hi Wei,

> > > > nit: I guess you want to replace dot with space in subject.
> > > You mean i s/attr.propagation/attr propagation ?

> > Yes.
> Will update it in v3

This is not important (the code matters), but IMHO something like:

"mount_setattr02: Add test to check mount attributes propagation"

would be more readable for me than "mount_setattr02.c: Check mount_setattr
attr.propagation" you provided. From your subject it's not even obvious it's a
new test and not a change in the existing test.

> > ...
> > > > > +#define DIRA "/DIRA_PROPAGATION_CHECK"

> > > > Is it necessary to to use directory under root?
> > > Yes. Otherwise failed will happen during mount_setattr.
> > > But i have not check for detail.

> > Ideally we would create files in TMPDIR. Specially if bug in the code leave
> > /DIRA_PROPAGATION_CHECK kept.
> Got it, will try using TMPDIR and investigate why it report error.

Thank you!

Kind regards,
Petr

> > > > ...
> > Sure, it should not block your work on the test.

> > Kind regards,
> > Petr

> > > > Kind regards,
> > > > Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp