From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] testcases/lib/run_tests.sh
Date: Fri, 28 Feb 2025 12:49:03 +0100 [thread overview]
Message-ID: <20250228114903.GA3228400@pevik> (raw)
In-Reply-To: <20250214133727.GA2221874@pevik>
Hi Cyril,
> > Enable TESTS_TBROK
> > diff --git a/testcases/lib/run_tests.sh b/testcases/lib/run_tests.sh
> > index 0abca2f3c..168dbb451 100755
> > --- a/testcases/lib/run_tests.sh
> > +++ b/testcases/lib/run_tests.sh
> > @@ -90,6 +90,7 @@ run_tests()
> > run_tests 0 $TESTS_PASS
> > run_tests 32 $TESTS_TCONF
> > +run_tests 2 $TESTS_TBROK
> Maybe also add $TESTS_FAIL (untested)?
> run_tests 1 $TESTS_FAIL
> Fixes: 29d8613dbd ("testcases/lib/run_tests.sh: Check expected results")
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
I dared to merge this obvious fix with adding also $TESTS_FAIL:
https://github.com/linux-test-project/ltp/commit/a92aedfabd5826d07809559508c8486c12ff7b96
+ sort by exit code, see following diff.
Thanks!
Kind regards,
Petr
> Thanks!
> Kind regards,
> Petr
+++ testcases/lib/run_tests.sh
@@ -89,8 +89,9 @@ run_tests()
}
run_tests 0 $TESTS_PASS
-run_tests 32 $TESTS_TCONF
+run_tests 1 $TESTS_FAIL
run_tests 2 $TESTS_TBROK
+run_tests 32 $TESTS_TCONF
echo
echo "*** Testing LTP test -h option ***"
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-02-28 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 11:21 [LTP] [PATCH 0/2] shell lib: Add very simple cleanup support Cyril Hrubis
2025-02-14 11:21 ` [LTP] [PATCH 1/2] testcases/lib/run_tests.sh Cyril Hrubis
2025-02-14 13:37 ` Petr Vorel
2025-02-28 11:49 ` Petr Vorel [this message]
2025-02-14 11:21 ` [LTP] [PATCH 2/2] shell lib: Add support for test cleanup Cyril Hrubis
2025-02-14 13:55 ` Petr Vorel
2025-02-14 14:07 ` Cyril Hrubis
2025-02-14 14:18 ` Cyril Hrubis
2025-02-17 7:44 ` Petr Vorel
2025-02-25 10:25 ` Cyril Hrubis
2025-02-25 11:00 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228114903.GA3228400@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox