Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel <pvorel@suse.cz>]

Hi Li,

> > > > > -%_16: CPPFLAGS += -D$(DEF_16)=1

> > > Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS?
> > > Or the
> > > LTP build system it just prepared to the crazy ideas about using C++? :)


> > No, I don't think so. I guess you memories it confused with CXXFLAGS :).

> > FYI:

> > CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
> > which is the first stage of compilation where macro substitution occurs,
> > and conditional compilation directives are processed. These flags are often
> > used to specify additional include directories.
> >     e.g. CPPFLAGS="-I/some/include/path"

> > CFLAGS (C Compiler Flags) are options for the C compiler. These
> > flags are often used to specify various compiler settings, such as
> > optimization level, warnings level, and debugging information.
> >     e.g.  CFLAGS="-O2 -g -Wall"

> > CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
> > It can be used to define options like optimization levels, debugging
> > information, warning levels, and more.
> >     e.g.  CXXFLAGS="-O2 -g -Wall"

> Ah, you're right. Thanks!

> > > > Seems we need to keep this one line, otherwise it can't transfer the
> > > > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.

> > > Ah, thanks!

> > > > The rest looks good to me.
> > > > Reviewed-by: Li Wang <liwang@redhat.com>

> > > BTW I'm going to push it with you as an author + with your Signed-off-by:
> > > tag
> > > (you're effectively the autor of the code) and with my RBT.


> > Sure, thanks for doing this for me.

> Yw.

Finally merged :).
(Obviously I forgot to merge back then although I set this in patchwork as accepted.)

Kind regards,
Petr

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp