[LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel]

From: Li Wang <liwang@redhat.com>

INTERMEDIATE object syntax is not necessary, thus remove it.

Suggested-by: Li Wang <liwang@redhat.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/utils/compat_16.mk | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/testcases/kernel/syscalls/utils/compat_16.mk b/testcases/kernel/syscalls/utils/compat_16.mk
index 71a8cc56f..8effa2b05 100644
--- a/testcases/kernel/syscalls/utils/compat_16.mk
+++ b/testcases/kernel/syscalls/utils/compat_16.mk
@@ -53,11 +53,8 @@ CPPFLAGS		+= -I$(abs_srcdir) -I$(abs_srcdir)/../utils
 SRCS			?= $(sort $(wildcard $(abs_srcdir)/*.c))
 
 MAKE_TARGETS		:= $(notdir $(patsubst %.c,%,$(SRCS)))
-MAKE_TARGETS_OBJS_WO_COMPAT_16	:= $(addsuffix .o,$(MAKE_TARGETS))
 MAKE_TARGETS		+= $(addsuffix _16,$(MAKE_TARGETS))
 
-# XXX (garrcoop): This code should be put in question as it cannot be applied
-# (no .h file, no TST_USE_NEWER64_SYSCALL def).
 DEF_16			:= TST_USE_COMPAT16_SYSCALL
 
 ifeq ($(USE_LEGACY_COMPAT_16_H),1)
@@ -66,13 +63,5 @@ else
 COMPAT_16_H     := $(abs_srcdir)/../utils/compat_tst_16.h
 endif
 
-ifneq ($(wildcard $(COMPAT_16_H)),)
-$(MAKE_TARGETS_OBJS_WO_COMPAT_16): $(COMPAT_16_H)
-.INTERMEDIATE: $(MAKE_TARGETS_OBJS_WO_COMPAT_16)
-endif
-
-%_16: CPPFLAGS += -D$(DEF_16)=1
-# XXX (garrcoop): End section of code in question..
-
 %_16.o: %.c $(COMPAT_16_H)
 	$(COMPILE.c) $(OUTPUT_OPTION) $<
-- 
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Li Wang]

Hi Petr,

Petr Vorel <pvorel@suse.cz> wrote:


>  DEF_16                 := TST_USE_COMPAT16_SYSCALL



> ...



> -%_16: CPPFLAGS += -D$(DEF_16)=1
>

Seems we need to keep this one line, otherwise it can't transfer the
'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.


The rest looks good to me.
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel]

Hi Li,

> Hi Petr,

> Petr Vorel <pvorel@suse.cz> wrote:


> >  DEF_16                 := TST_USE_COMPAT16_SYSCALL



> > ...



> > -%_16: CPPFLAGS += -D$(DEF_16)=1

Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS? Or the
LTP build system it just prepared to the crazy ideas about using C++? :)


> Seems we need to keep this one line, otherwise it can't transfer the
> 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.

Ah, thanks!

> The rest looks good to me.
> Reviewed-by: Li Wang <liwang@redhat.com>

BTW I'm going to push it with you as an author + with your Signed-off-by: tag
(you're effectively the autor of the code) and with my RBT.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Li Wang]

> > > -%_16: CPPFLAGS += -D$(DEF_16)=1
>
> Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS?
> Or the
> LTP build system it just prepared to the crazy ideas about using C++? :)
>

No, I don't think so. I guess you memories it confused with CXXFLAGS :).

FYI:

CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
which is the first stage of compilation where macro substitution occurs,
and conditional compilation directives are processed. These flags are often
used to specify additional include directories.
    e.g. CPPFLAGS="-I/some/include/path"

CFLAGS (C Compiler Flags) are options for the C compiler. These
flags are often used to specify various compiler settings, such as
optimization level, warnings level, and debugging information.
    e.g.  CFLAGS="-O2 -g -Wall"

CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
It can be used to define options like optimization levels, debugging
information, warning levels, and more.
    e.g.  CXXFLAGS="-O2 -g -Wall"



> > Seems we need to keep this one line, otherwise it can't transfer the
> > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.
>
> Ah, thanks!
>
> > The rest looks good to me.
> > Reviewed-by: Li Wang <liwang@redhat.com>
>
> BTW I'm going to push it with you as an author + with your Signed-off-by:
> tag
> (you're effectively the autor of the code) and with my RBT.
>

Sure, thanks for doing this for me.

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel]

> > > > -%_16: CPPFLAGS += -D$(DEF_16)=1

> > Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS?
> > Or the
> > LTP build system it just prepared to the crazy ideas about using C++? :)


> No, I don't think so. I guess you memories it confused with CXXFLAGS :).

> FYI:

> CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
> which is the first stage of compilation where macro substitution occurs,
> and conditional compilation directives are processed. These flags are often
> used to specify additional include directories.
>     e.g. CPPFLAGS="-I/some/include/path"

> CFLAGS (C Compiler Flags) are options for the C compiler. These
> flags are often used to specify various compiler settings, such as
> optimization level, warnings level, and debugging information.
>     e.g.  CFLAGS="-O2 -g -Wall"

> CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
> It can be used to define options like optimization levels, debugging
> information, warning levels, and more.
>     e.g.  CXXFLAGS="-O2 -g -Wall"

Ah, you're right. Thanks!

> > > Seems we need to keep this one line, otherwise it can't transfer the
> > > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.

> > Ah, thanks!

> > > The rest looks good to me.
> > > Reviewed-by: Li Wang <liwang@redhat.com>

> > BTW I'm going to push it with you as an author + with your Signed-off-by:
> > tag
> > (you're effectively the autor of the code) and with my RBT.


> Sure, thanks for doing this for me.

Yw.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel]

Hi Li,

> > > > > -%_16: CPPFLAGS += -D$(DEF_16)=1

> > > Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS?
> > > Or the
> > > LTP build system it just prepared to the crazy ideas about using C++? :)


> > No, I don't think so. I guess you memories it confused with CXXFLAGS :).

> > FYI:

> > CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
> > which is the first stage of compilation where macro substitution occurs,
> > and conditional compilation directives are processed. These flags are often
> > used to specify additional include directories.
> >     e.g. CPPFLAGS="-I/some/include/path"

> > CFLAGS (C Compiler Flags) are options for the C compiler. These
> > flags are often used to specify various compiler settings, such as
> > optimization level, warnings level, and debugging information.
> >     e.g.  CFLAGS="-O2 -g -Wall"

> > CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
> > It can be used to define options like optimization levels, debugging
> > information, warning levels, and more.
> >     e.g.  CXXFLAGS="-O2 -g -Wall"

> Ah, you're right. Thanks!

> > > > Seems we need to keep this one line, otherwise it can't transfer the
> > > > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.

> > > Ah, thanks!

> > > > The rest looks good to me.
> > > > Reviewed-by: Li Wang <liwang@redhat.com>

> > > BTW I'm going to push it with you as an author + with your Signed-off-by:
> > > tag
> > > (you're effectively the autor of the code) and with my RBT.


> > Sure, thanks for doing this for me.

> Yw.

Finally merged :).
(Obviously I forgot to merge back then although I set this in patchwork as accepted.)

Kind regards,
Petr

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Li Wang]

On Sat, Mar 8, 2025 at 7:46 AM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> > > > > > -%_16: CPPFLAGS += -D$(DEF_16)=1
>
> > > > Not related to this effort: shouldn't we convert all CPPFLAGS to
> CFLAGS?
> > > > Or the
> > > > LTP build system it just prepared to the crazy ideas about using
> C++? :)
>
>
> > > No, I don't think so. I guess you memories it confused with CXXFLAGS
> :).
>
> > > FYI:
>
> > > CPPFLAGS (C PreProcessor Flags) are options for the C preprocessor,
> > > which is the first stage of compilation where macro substitution
> occurs,
> > > and conditional compilation directives are processed. These flags are
> often
> > > used to specify additional include directories.
> > >     e.g. CPPFLAGS="-I/some/include/path"
>
> > > CFLAGS (C Compiler Flags) are options for the C compiler. These
> > > flags are often used to specify various compiler settings, such as
> > > optimization level, warnings level, and debugging information.
> > >     e.g.  CFLAGS="-O2 -g -Wall"
>
> > > CXXFLAGS (C++ Compiler Flags) are options for the C++ compiler.
> > > It can be used to define options like optimization levels, debugging
> > > information, warning levels, and more.
> > >     e.g.  CXXFLAGS="-O2 -g -Wall"
>
> > Ah, you're right. Thanks!
>
> > > > > Seems we need to keep this one line, otherwise it can't transfer
> the
> > > > > 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.
>
> > > > Ah, thanks!
>
> > > > > The rest looks good to me.
> > > > > Reviewed-by: Li Wang <liwang@redhat.com>
>
> > > > BTW I'm going to push it with you as an author + with your
> Signed-off-by:
> > > > tag
> > > > (you're effectively the autor of the code) and with my RBT.
>
>
> > > Sure, thanks for doing this for me.
>
> > Yw.
>
> Finally merged :).
> (Obviously I forgot to merge back then although I set this in patchwork as
> accepted.)
>

Well, thanks!! I'm wondering how you find this one being missed, it's been
so long:).


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax

[Petr Vorel]

> > Finally merged :).
> > (Obviously I forgot to merge back then although I set this in patchwork as
> > accepted.)


> Well, thanks!! I'm wondering how you find this one being missed, it's been
> so long:).

Trying to tidy up messy branches in my fork :).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp