From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F62C36000 for ; Fri, 21 Mar 2025 15:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it; i=@lists.linux.it; q=dns/txt; s=picard; t=1742570665; h=date : to : message-id : references : mime-version : in-reply-to : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : from : reply-to : cc : content-type : content-transfer-encoding : sender : from; bh=ANo6ZzfTbzWKRp5kP4jtgHV7bxFV2yO9s9JaSc6lI8E=; b=OvC30XeaDiGCgMVa4jDu9R0eZ1MxEpEuK0D7xvaoaTB/f/RI2CQwI1qHVNRoSDNC79EWm E+BUOpl4wRl6e0gJXJnLxm2V4bpuQEuT8gZ5VOzEqwrMfi93Lz1BO0YrEQDtDy2w2f62Cp6 4Sr8Bvk82ABjYmCJw31tggl0eyHZwec= Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EEC343CAE82 for ; Fri, 21 Mar 2025 16:24:24 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A41723C08A6 for ; Fri, 21 Mar 2025 16:24:02 +0100 (CET) Authentication-Results: in-4.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=djwong@kernel.org; receiver=lists.linux.it) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id DE17A10006D5 for ; Fri, 21 Mar 2025 16:24:00 +0100 (CET) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2833D5C5D6D; Fri, 21 Mar 2025 15:21:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C456CC4CEE3; Fri, 21 Mar 2025 15:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742570638; bh=NQ8pijVfk1rTFuW4NFJBHdEGWPZqqhKoJOUnCF4Ftsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=coabSd43a3rEsvgw8RRsXqG7emvaxkYxMzdNS/kcPtqo/Kx+Plln0YUsNSlDJQdvM 2Mk1excV7iBvf6YQbT7p1mI4WrPiCSTZURn4RGKyAsEpNXMIxtpiJWCkz0twRxZQGZ HPHvUEITVAo0P5c6xXgfqWpzTjx3xDRGzO/JGf8eL1SbZKTfDEwJxy6eUVOxCCJh26 sfuVGT97GIa+TjMlgGNzDkl+ZV1NElSbxqdjENUXA4LiF6r6wNh5V41ejZtyg47s4t 4CDPuPJ4L+Cg02jF75wwhqs2CcRtPqTcYIUGaJNYP/BUXJgNDl65WcMwSTM0fjXFtX OE0+OX3/e4WWw== Date: Fri, 21 Mar 2025 08:23:58 -0700 To: Petr Vorel Message-ID: <20250321152358.GK2803749@frogsfrogsfrogs> References: <20250321100320.162107-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250321100320.162107-1-pvorel@suse.cz> X-Virus-Scanned: clamav-milter 1.0.3 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCH 1/1] ioctl_ficlone03: Require 5.10 for XFS X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Darrick J. Wong via ltp" Reply-To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, Gao Xiang , "Darrick J . Wong" , fstests@vger.kernel.org, Allison Collins , Dave Chinner , Jan Kara , Christoph Hellwig , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" On Fri, Mar 21, 2025 at 11:03:20AM +0100, Petr Vorel wrote: > Test fails on XFS on kernel older than 5.10: > > # ./ioctl_ficlone03 > ... > tst_test.c:1183: TINFO: Mounting /dev/loop0 to /tmp/LTP_ioc6ARHZ7/mnt fstyp=xfs flags=0 > [ 10.122070] XFS (loop0): Superblock has unknown incompatible features (0x8) enabled. 0x8 is XFS_SB_FEAT_INCOMPAT_BIGTIME, maybe you need to format with a set of filesystem features compatible with 5.10? # mkfs.xfs -c options=/usr/share/xfsprogs/mkfs/lts_5.10.conf /dev/sda1 --D > [ 10.123035] XFS (loop0): Filesystem cannot be safely mounted by this kernel. > [ 10.123916] XFS (loop0): SB validate failed with error -22. > tst_test.c:1183: TBROK: mount(/dev/loop0, mnt, xfs, 0, (nil)) failed: EINVAL (22) > > This also causes Btrfs testing to be skipped due TBROK on XFS. With increased version we get on 5.4 LTS: > > # ./ioctl_ficlone03 > tst_test.c:1904: TINFO: Tested kernel: 5.4.291 #194 SMP Fri Mar 21 10:18:02 CET 2025 x86_64 > ... > tst_supported_fs_types.c:49: TINFO: mkfs is not needed for tmpfs > tst_test.c:1833: TINFO: === Testing on xfs === > tst_cmd.c:281: TINFO: Parsing mkfs.xfs version > tst_test.c:969: TCONF: The test requires kernel 5.10 or newer > tst_test.c:1833: TINFO: === Testing on btrfs === > tst_test.c:1170: TINFO: Formatting /dev/loop0 with btrfs opts='' extra opts='' > [ 30.143670] BTRFS: device fsid 1a6d250c-0636-11f0-850f-c598bdcd84c4 devid 1 transid 6 /dev/loop0 > tst_test.c:1183: TINFO: Mounting /dev/loop0 to /tmp/LTP_iocjwzyal/mnt fstyp=btrfs flags=0 > [ 30.156563] BTRFS info (device loop0): using crc32c (crc32c-generic) checksum algorithm > [ 30.157363] BTRFS info (device loop0): flagging fs with big metadata feature > [ 30.158061] BTRFS info (device loop0): using free space tree > [ 30.158620] BTRFS info (device loop0): has skinny extents > [ 30.159911] BTRFS info (device loop0): enabling ssd optimizations > [ 30.160652] BTRFS info (device loop0): checking UUID tree > ioctl_ficlone03_fix.c:49: TPASS: invalid source : EBADF (9) > ioctl_ficlone03_fix.c:55: TPASS: invalid source : EBADF (9) > > Fixing commit is 29887a2271319 ("xfs: enable big timestamps"). > > Signed-off-by: Petr Vorel > --- > Hi all, > > I suppose we aren't covering a test bug with this and test is really > wrong expecting 4.16 would work on XFS. FYI this affects 5.4.291 > (latest 5.4 LTS which is still supported) and would not be fixed due a > lot of missing functionality from 5.10. > > Kind regards, > Petr > > testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c > index 6a9d270d9f..e2ab10cba1 100644 > --- a/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c > +++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlone03.c > @@ -113,7 +113,7 @@ static struct tst_test test = { > {.type = "bcachefs"}, > { > .type = "xfs", > - .min_kver = "4.16", > + .min_kver = "5.10", > .mkfs_ver = "mkfs.xfs >= 1.5.0", > .mkfs_opts = (const char *const []) {"-m", "reflink=1", NULL}, > }, > -- > 2.47.2 > > -- Mailing list info: https://lists.linux.it/listinfo/ltp