From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2F04C3600B for ; Mon, 31 Mar 2025 17:54:05 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 12F643CAD82 for ; Mon, 31 Mar 2025 19:54:04 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id AEA533CABC9 for ; Mon, 31 Mar 2025 19:53:46 +0200 (CEST) Authentication-Results: in-7.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D72AF200345 for ; Mon, 31 Mar 2025 19:53:45 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2B714211C6; Mon, 31 Mar 2025 17:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743443624; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AhKrrXnV5mrYB4shjT0jbxOocV+rnJ6l7iGgrpiOsiE=; b=cdpCuM8e4PLZb4eqPdutunupLT4gl+7bzPagdk3b+TEBI7yUVf1N8WgoWRVIUBavGKafIe cs8xLEHO7JVp+WhZC8AhlZRi3udBNGVE2OvZnf3s01Xdzyy5Hw+SU4LK+EtQQkrovPlJtd NYRqF/AMsQct6SyNMTRpgcWZxg7TGwU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743443624; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AhKrrXnV5mrYB4shjT0jbxOocV+rnJ6l7iGgrpiOsiE=; b=Z/SgyBg5R+uYsopynkiroFcQ6M3oOEx2H33vWAPiFJlIHuz+Nwe6vXAKOl1ihHnL6HWrLA TfcOOs+fpEpld+Ag== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743443624; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AhKrrXnV5mrYB4shjT0jbxOocV+rnJ6l7iGgrpiOsiE=; b=cdpCuM8e4PLZb4eqPdutunupLT4gl+7bzPagdk3b+TEBI7yUVf1N8WgoWRVIUBavGKafIe cs8xLEHO7JVp+WhZC8AhlZRi3udBNGVE2OvZnf3s01Xdzyy5Hw+SU4LK+EtQQkrovPlJtd NYRqF/AMsQct6SyNMTRpgcWZxg7TGwU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743443624; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AhKrrXnV5mrYB4shjT0jbxOocV+rnJ6l7iGgrpiOsiE=; b=Z/SgyBg5R+uYsopynkiroFcQ6M3oOEx2H33vWAPiFJlIHuz+Nwe6vXAKOl1ihHnL6HWrLA TfcOOs+fpEpld+Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA82B13A1F; Mon, 31 Mar 2025 17:53:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fYlIN6fW6mcHeAAAD6G6ig (envelope-from ); Mon, 31 Mar 2025 17:53:43 +0000 Date: Mon, 31 Mar 2025 19:53:42 +0200 From: Petr Vorel To: Andrea Cervesato Message-ID: <20250331175342.GA276600@pevik> References: <20250328095747.169011-1-pvorel@suse.cz> <20250328095747.169011-3-pvorel@suse.cz> <20250331163120.GA220855@pevik> <20250331163726.GB220855@pevik> <9be4b701-40b8-4ada-a7cb-ff8ab1931a7b@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9be4b701-40b8-4ada-a7cb-ff8ab1931a7b@suse.com> X-Spamd-Result: default: False [-3.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:replyto]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.3 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 2/5] doc: Add sphinx to requirements.txt X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Ricardo =?utf-8?B?Qi4gTWFybGnDqHJl?= , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On 3/31/25 18:37, Petr Vorel wrote: > > Wait, one thing: we use doc/requirements.txt in .readthedocs.yml. Is it really a > > good idea to add there sphinx, when it uses containers? I can test it in a > > separate branch, but we discussed some time ago that we should avoid adding > > sphinx for readthedocs. > > Wouldn't be in the end better to keep 'pip install sphinx' in Makefile instead > > (the previous proposal). > > Kind regards, > > Petr > I forgot about it. Thanks for remembering. At the moment readthedocs > installs sphinx via pip, so if we add just sphinx ro requirements.txt > without version, pip should reinstall the same version which is already > available before building the website. > We should give a try and eventually get back to the old way. To be honest I would prefer to avoid experimenting with readthedoc as much as possible. How about just forcing 'pip install sphinx' only in Makefile? It can be the simplest version - without checking if it's installed. Because I don't see any benefit to add sphinx to readthedocs where it's not needed - in the best case it will takes time to reinstall, in worst it just take time to experiment to find it breaks things. We are going to diverge from readthedocs anyway, unless we manually sync with the sphinx version it uses. You asked for newest version (which is 8.2.3, if I don't count broken 8.3), but in readthedocs we use old ubuntu-22.04, which uses sphinx 4.3.2 [1]. We could update to noble (24.04LTS) (if supported by readthedocs) to get newer 7.2.6 (as I can test it as a separate effort. [1] https://packages.ubuntu.com/jammy/python3-sphinx [2] https://packages.ubuntu.com/noble/python3-sphinx I guess controlling the version is important, therefore I would prefer b) or c). a) simple version in Makefile, without version: $(VENV_DIR): $(PYTHON) -m virtualenv $(VENV_DIR) $(VENV_CMD) && pip install sphinx && pip install -r requirements.txt b) simple version with specifying sphinx version: SPHINX_VERSION := 8.2.3 # or 7.2.6 or 4.3.2? ... $(VENV_DIR): $(PYTHON) -m virtualenv $(VENV_DIR) $(VENV_CMD) && pip install sphinx==$(SPHINX_VERSION) && pip install -r requirements.txt c) more complicated version (you did not like) which install sphinx only when needed: SPHINX_VERSION := 8.2.3 INSTALL_SPHINX := $(shell $(PYTHON) -c "import sphinx" 2>/dev/null && echo ":" || echo "pip install sphinx==$(SPHINX_VERSION)") ... $(VENV_DIR): $(PYTHON) -m virtualenv $(VENV_DIR) $(VENV_CMD) && pip install -r requirements.txt && $(INSTALL_SPHINX) Kind regards, Petr > Andrea -- Mailing list info: https://lists.linux.it/listinfo/ltp